From 3d0c39b3a45878dfc029f42c67a0782633440bcf Mon Sep 17 00:00:00 2001 From: Raghu Simha Date: Mon, 22 Feb 2021 16:03:26 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=8F=97=20Sync=20Chrome=20version=20used?= =?UTF-8?q?=20by=20Visual=20tests=20with=20Percy=20backend=20(#32774)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- build-system/tasks/visual-diff/index.js | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/build-system/tasks/visual-diff/index.js b/build-system/tasks/visual-diff/index.js index 9ce04b11b351..f4e8cbdc1190 100644 --- a/build-system/tasks/visual-diff/index.js +++ b/build-system/tasks/visual-diff/index.js @@ -57,11 +57,18 @@ const percyCss = [ '.i-amphtml-new-loader * { animation: none !important; }', ].join('\n'); -// Pin the version of Chromium to 78.0.3904.0, same as the one running on Percy. -// Use https://omahaproxy.appspot.com/ to convert version<->revision numbers. -// REPEATING TODO(@ampproject/wg-infra): keep this pinned with Percy whenever we -// update the version of Chrome in the project settings. -const PUPPETEER_CHROMIUM_REVISION = '693954'; +// REPEATING TODO(@ampproject/wg-infra): Update this whenever the Percy backend +// starts using a new version of Chrome to render DOM snapshots. +// +// Steps: +// 1. Open a recent Percy build, and click the “ⓘ” icon +// 2. Note the Chrome major version at the bottom +// 3. Look up the full version at https://en.wikipedia.org/wiki/Google_Chrome_version_history +// 4. Open https://omahaproxy.appspot.com in a browser +// 5. Go to "Tools" -> "Version information" +// 6. Paste the full version in the "Version" field and click "Lookup" +// 7. Copy the value next to "Branch Base Position" and update the line below +const PUPPETEER_CHROMIUM_REVISION = '827102'; // 88.0.4324.0 const SNAPSHOT_SINGLE_BUILD_OPTIONS = { widths: [375],