From 5067a21eb2130763ebc03fab4aea1f96c075fea9 Mon Sep 17 00:00:00 2001
From: zhouyx <zhouyx@google.com>
Date: Fri, 10 Apr 2020 11:07:52 -0700
Subject: [PATCH] add promise

---
 .../0.1/test-e2e/test-amp-consent-client-side.js      | 11 +++++------
 .../0.1/test-e2e/test-amp-consent-server-side.js      |  7 +++++--
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/extensions/amp-consent/0.1/test-e2e/test-amp-consent-client-side.js b/extensions/amp-consent/0.1/test-e2e/test-amp-consent-client-side.js
index f1010aaaa8b2..ee3c3afa90ea 100644
--- a/extensions/amp-consent/0.1/test-e2e/test-amp-consent-client-side.js
+++ b/extensions/amp-consent/0.1/test-e2e/test-amp-consent-client-side.js
@@ -39,7 +39,6 @@ describes.endtoend(
     it('should work with client side decision', async () => {
       resetAllElements();
       const currentUrl = await controller.getCurrentUrl();
-      //console.log('currentUrl is  ', currentUrl);
 
       // Verify no local storage decision
       await findElements(controller);
@@ -96,11 +95,11 @@ describes.endtoend(
         'postPromptUi': false,
       });
 
-      // Check the analytics request consentState
-      // const p = new Promise((resolve) => {
-      //   setTimeout(resolve, 1000);
-      // });
-      // await p;
+      // Check the analytics request consentState. Wait for 1 second for the
+      // request to arrive to avoid flaky test.
+      await new Promise((resolve) => {
+        setTimeout(resolve, 1000);
+      });
       await expect(
         'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=sufficient'
       ).to.have.been.sent;
diff --git a/extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side.js b/extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side.js
index cf68d9b496aa..60e03060b124 100644
--- a/extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side.js
+++ b/extensions/amp-consent/0.1/test-e2e/test-amp-consent-server-side.js
@@ -36,7 +36,6 @@ describes.endtoend(
       controller = env.controller;
     });
 
-    //TODO (micajuineho): Unskip flaky test
     it('should respect server side decision and persist it', async () => {
       resetAllElements();
 
@@ -79,7 +78,11 @@ describes.endtoend(
         'postPromptUi': false,
       });
 
-      // Check the analytics request consentState
+      // Check the analytics request consentState. Wait for 1 second for the
+      // request to arrive to avoid flaky test.
+      await new Promise((resolve) => {
+        setTimeout(resolve, 1000);
+      });
       await expect(
         'http://localhost:8000/amp4test/request-bank/e2e/deposit/tracking?consentState=insufficient'
       ).to.have.been.sent;