diff --git a/extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.html b/extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.html index aaaa80d98ede..ed43284d6062 100644 --- a/extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.html +++ b/extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.html @@ -60,5 +60,8 @@ + + + diff --git a/extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.out b/extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.out index c035e25dc6e5..c4367466a1d6 100644 --- a/extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.out +++ b/extensions/amp-dailymotion/0.1/test/validator-amp-dailymotion.out @@ -67,5 +67,10 @@ amp-dailymotion/0.1/test/validator-amp-dailymotion.html:55:0 The attribute 'data | | +| +| +| +>> ^~~~~~~~~ +amp-dailymotion/0.1/test/validator-amp-dailymotion.html:65:0 The attribute 'dock' requires including the 'amp-video-docking' extension JavaScript. [MANDATORY_AMP_TAG_MISSING_OR_INCORRECT] | -| +| \ No newline at end of file diff --git a/extensions/amp-dailymotion/amp-dailymotion.md b/extensions/amp-dailymotion/amp-dailymotion.md index 184e3caaf716..9848b68e9583 100644 --- a/extensions/amp-dailymotion/amp-dailymotion.md +++ b/extensions/amp-dailymotion/amp-dailymotion.md @@ -134,6 +134,11 @@ With responsive layout, the width and height from the example should yield corre

Please read Dailymotion's video player documentation to know more about parameters and options.

+ + dock + Requires amp-video-docking extension. If this attribute is present and the video is playing manually, the video will be "minimized" and fixed to a corner or an element when the user scrolls out of the video component's visual area. + For more details, see documentation on the docking extension itself. + common attributes This element includes common attributes extended to AMP components. diff --git a/extensions/amp-dailymotion/validator-amp-dailymotion.protoascii b/extensions/amp-dailymotion/validator-amp-dailymotion.protoascii index 72dab74e0e6a..d897380f8fa2 100644 --- a/extensions/amp-dailymotion/validator-amp-dailymotion.protoascii +++ b/extensions/amp-dailymotion/validator-amp-dailymotion.protoascii @@ -68,6 +68,10 @@ tags: { # mandatory: true value_regex_casei: "[a-z0-9]+" } + attrs: { + name: "dock" + requires_extension: "amp-video-docking" + } attr_lists: "extended-amp-global" spec_url: "https://www.ampproject.org/docs/reference/components/amp-dailymotion" amp_layout: { diff --git a/extensions/amp-video-docking/0.1/test/validator-amp-video-docking-amp-dailymotion.html b/extensions/amp-video-docking/0.1/test/validator-amp-video-docking-amp-dailymotion.html new file mode 100644 index 000000000000..3e9af8a0adb3 --- /dev/null +++ b/extensions/amp-video-docking/0.1/test/validator-amp-video-docking-amp-dailymotion.html @@ -0,0 +1,38 @@ + + + + + + + + + + + + + + + + + + + diff --git a/extensions/amp-video-docking/0.1/test/validator-amp-video-docking-amp-dailymotion.out b/extensions/amp-video-docking/0.1/test/validator-amp-video-docking-amp-dailymotion.out new file mode 100644 index 000000000000..ef7c1f28589b --- /dev/null +++ b/extensions/amp-video-docking/0.1/test/validator-amp-video-docking-amp-dailymotion.out @@ -0,0 +1,39 @@ +PASS +| +| +| +| +| +| +| +| +| +| +| +| +| +| +| +| +| +| +| \ No newline at end of file diff --git a/extensions/amp-video-docking/amp-video-docking.md b/extensions/amp-video-docking/amp-video-docking.md index 888ac1fd49f4..b2ca7012415d 100644 --- a/extensions/amp-video-docking/amp-video-docking.md +++ b/extensions/amp-video-docking/amp-video-docking.md @@ -63,6 +63,7 @@ This extension is used in conjunction with a [supported video player](../../spec Currently, the supported players are: - [`amp-brightcove`](https://www.ampproject.org/docs/reference/components/amp-brightcove) +- [`amp-dailymotion`](https://www.ampproject.org/docs/reference/components/amp-dailymotion) - [`amp-ima-video`](https://www.ampproject.org/docs/reference/components/amp-ima-video) - [`amp-video`](https://www.ampproject.org/docs/reference/components/amp-video) - [`amp-video-iframe`](https://www.ampproject.org/docs/reference/components/amp-youtube) diff --git a/spec/amp-video-interface.md b/spec/amp-video-interface.md index 6d8d10f0f167..f8d63ad729d0 100644 --- a/spec/amp-video-interface.md +++ b/spec/amp-video-interface.md @@ -49,7 +49,7 @@ For an example, visit [AMP By Example](https://ampbyexample.com/components/amp-v attribute: **`dock`** This attribute is currently only supported for -`amp-brightcove`, `amp-ima-video`, `amp-video`, `amp-video-iframe` and `amp-youtube`. +`amp-brightcove`, `amp-dailymotion`, `amp-ima-video`, `amp-video`, `amp-video-iframe` and `amp-youtube`. If this attribute is present and the video is playing manually, the video will be "minimized" and fixed to a corner when the user scrolls out of the video