From 6e96ca13f4ff4088eb1a31af25d95ca621d078f5 Mon Sep 17 00:00:00 2001 From: Boxiao Cao <9083193+antiphoton@users.noreply.github.com> Date: Wed, 8 Sep 2021 13:47:13 -0700 Subject: [PATCH] Use docker node image --- validator/README.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/validator/README.md b/validator/README.md index 118638964af0b..11c8d3cb65034 100644 --- a/validator/README.md +++ b/validator/README.md @@ -129,19 +129,18 @@ Now `cd amphtml/validator` and run `python build.py`. In the case the test passes in your local machine but fails in Circle CI, you can use docker to reproduce the test errors. -1. Start an interacitve docker container +1. Start an interactive docker container ```bash - docker run -it ubuntu bash + docker run -it node:lts-buster bash ``` 1. Run following commands in the container. Note that you are already the `root` user inside the docker container. ```bash apt update - apt install -y curl git gpg sudo - curl -fsSL https://deb.nodesource.com/setup_16.x | bash - - apt install -y nodejs + apt install -y sudo git clone https://github.com/ampproject/amphtml.git cd amphtml npm install + npm run postinstall .circleci/install_validator_dependencies.sh amp validator-cpp && echo SUCCESS || echo FAIL ```