From 773b80a12e1e6e5148c87536dcfeeaf748cb9907 Mon Sep 17 00:00:00 2001
From: Daniel Rozenberg <rodaniel@amp.dev>
Date: Wed, 6 Mar 2024 15:54:23 -0500
Subject: [PATCH] =?UTF-8?q?=E2=9D=84=EF=B8=8F=20Flaky=20tests=20(#39877)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Attempt at deflaking amp-consent tests
* Disable flaky test
* Disable flaky test
---
 extensions/amp-analytics/0.1/test/test-events.js           | 3 ++-
 extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js | 3 ++-
 extensions/amp-consent/0.1/test/test-amp-consent.js        | 4 ++--
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/extensions/amp-analytics/0.1/test/test-events.js b/extensions/amp-analytics/0.1/test/test-events.js
index 81c00f5b89b1..125147bc3cf3 100644
--- a/extensions/amp-analytics/0.1/test/test-events.js
+++ b/extensions/amp-analytics/0.1/test/test-events.js
@@ -1394,7 +1394,8 @@ describes.realWin('Events', {amp: 1}, (env) => {
       });
     });
 
-    it(
+    // TODO(#39879): fix this flaky test.
+    it.skip(
       'timers started and stopped by the same event on the same target' +
         ' do not have race condition problems',
       () => {
diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js b/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js
index 6a5136cbd72e..c2060294d509 100644
--- a/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js
+++ b/extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js
@@ -59,7 +59,8 @@ describes.endtoend(
       await expect(slidesRects[0].width).to.equal(pageWidth);
     });
 
-    it('should layout the two adjacent slides', async function () {
+    // TODO(#24195): fix this flaky test.
+    it.skip('should layout the two adjacent slides', async function () {
       const [firstSlideRect, secondSlideRect, lastSlideRect] = [
         await controller.getElementRect(await getSlide(controller, 0)),
         await controller.getElementRect(await getSlide(controller, 1)),
diff --git a/extensions/amp-consent/0.1/test/test-amp-consent.js b/extensions/amp-consent/0.1/test/test-amp-consent.js
index d3b76a9dd661..f367b84a6427 100644
--- a/extensions/amp-consent/0.1/test/test-amp-consent.js
+++ b/extensions/amp-consent/0.1/test/test-amp-consent.js
@@ -4,7 +4,7 @@ import {xhrServiceForTesting} from '#service/xhr-impl';
 
 import {dev, user} from '#utils/log';
 
-import {macroTask} from '#testing/helpers';
+import {macroTask, sleep} from '#testing/helpers';
 
 import {
   registerServiceBuilder,
@@ -1161,7 +1161,7 @@ describes.realWin(
 
         beforeEach(async () => {
           ampConsent.buildCallback();
-          await macroTask();
+          await sleep(50);
           managerSpy = env.sandbox.spy(
             ampConsent.consentStateManager_,
             'updateConsentInstancePurposes'