From 8d1fe374db49e1bb71dbefa2701b4978269474f1 Mon Sep 17 00:00:00 2001 From: ColombiaOnline Date: Wed, 4 Aug 2021 22:19:57 +0530 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20Refactor=20[Colombia=20Ana?= =?UTF-8?q?lytics]=20-=20Added=20new=20parameters=20and=20removed=20unused?= =?UTF-8?q?=20ones.=20=20(#35278)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * add policy attributes * add owners * update files for Owners. * Revert file * Dmp Analytics event trigger related changes * Pull request review comments for indentation incorporated * Indentation corrected and unused code changes removed * Spaces and newline reveiw comment incorporation done. * Unit test failure input corrected * Unit test input data updated * Indentation corrected --- .../amp-analytics/0.1/test/vendor-requests.json | 3 ++- .../amp-analytics/0.1/vendors/colanalytics.json | 13 ++++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/extensions/amp-analytics/0.1/test/vendor-requests.json b/extensions/amp-analytics/0.1/test/vendor-requests.json index e40d7478defe..869687dc4839 100644 --- a/extensions/amp-analytics/0.1/test/vendor-requests.json +++ b/extensions/amp-analytics/0.1/test/vendor-requests.json @@ -88,7 +88,8 @@ "colanalytics": { "host": "https://ase.clmbtech.com", "base": "https://ase.clmbtech.com/message", - "pageview": "https://ase.clmbtech.com/message?cid=!id&val_101=!id&val_101=_canonical_path_&ch=_canonical_host_&uuid=!uid&au=!authors&zo=!zone&sn=!sponsorName&ct=!contentType&st=_scroll_top_&sh=_scroll_height_&dct=!decayTime&tet=_total_engaged_time_&dr=_document_referrer_&plt=_page_load_time_&val_108=_title_&val_120=3" + "pageview": "https://ase.clmbtech.com/message?cid=!id&val_101=!id&val_101=int%3A_canonical_path_&ch=_canonical_host_&val_108=_title_&val_120=3&val_102=_source_url_&val_124=_external_referrer_&uuid=!uid", + "event": "https://ase.clmbtech.com/message?cid=!id&val_101=!id&val_101=int%3A_canonical_path_&val_101=tet%3A_total_engaged_time_&val_102=clk%3Apg%3A_source_url_" }, "comscore": { "host": "https://sb.scorecardresearch.com", diff --git a/extensions/amp-analytics/0.1/vendors/colanalytics.json b/extensions/amp-analytics/0.1/vendors/colanalytics.json index b0b0006c99f6..df9def549929 100644 --- a/extensions/amp-analytics/0.1/vendors/colanalytics.json +++ b/extensions/amp-analytics/0.1/vendors/colanalytics.json @@ -2,12 +2,23 @@ "requests": { "host": "https://ase.clmbtech.com", "base": "${host}/message", - "pageview": "${base}?cid=${id}&val_101=${id}&val_101=${canonicalPath}&ch=${canonicalHost}&uuid=${uid}&au=${authors}&zo=${zone}&sn=${sponsorName}&ct=${contentType}&st=${scrollTop}&sh=${scrollHeight}&dct=${decayTime}&tet=${totalEngagedTime}&dr=${documentReferrer}&plt=${pageLoadTime}&val_108=${title}&val_120=3" + "pageview": "${base}?cid=${id}&val_101=${id}&val_101=${int}${canonicalPath}&ch=${canonicalHost}&val_108=${title}&val_120=3&val_102=${sourceUrl}&val_124=${externalReferrer}&uuid=${uid}", + "event": "${base}?cid=${id}&val_101=${id}&val_101=${int}${canonicalPath}&val_101=${tet}${totalEngagedTime}&val_102=${clk}${sourceUrl}" + }, + "vars": { + "int": "int:", + "clk": "clk:pg:", + "tet": "tet:" }, "triggers": { "defaultPageview": { "on": "visible", "request": "pageview" + }, + "anchorClicks": { + "on": "click", + "selector": "a", + "request": "event" } }, "transport": {