From 8fe474ab47bf34cb93816a43593b545ee8363d9d Mon Sep 17 00:00:00 2001 From: Aaron Turner Date: Tue, 27 Jun 2017 15:51:53 -0700 Subject: [PATCH] Fixed the missing ownerDocument on the container This fixed missing toolbar element classes within the iframe --- .../amp-sidebar/1.0/test/test-toolbar.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/extensions/amp-sidebar/1.0/test/test-toolbar.js b/extensions/amp-sidebar/1.0/test/test-toolbar.js index f587c4550398..d9059824263b 100644 --- a/extensions/amp-sidebar/1.0/test/test-toolbar.js +++ b/extensions/amp-sidebar/1.0/test/test-toolbar.js @@ -25,7 +25,7 @@ const DEFAULT_TOOLBAR_MEDIA = '(min-width: 768px)'; /** @const */ - const TOOLBAR_CLASS = 'i-amphtml-toolbar'; + const TOOLBAR_ELEMENT_CLASS = 'i-amphtml-toolbar'; adopt(window); @@ -111,7 +111,7 @@ const toolbars = obj.toolbars; const toolbarElements = Array.prototype .slice.call(obj.toolbarContainerElement.ownerDocument - .getElementsByClassName(TOOLBAR_CLASS), 0); + .getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0); resizeIframeToWidth(obj.iframe, '1px', () => { expect(toolbarElements.length).to.be.above(0); toolbars.forEach(toolbar => { @@ -128,8 +128,8 @@ return getToolbars([{}]).then(obj => { const toolbars = obj.toolbars; const toolbarElements = Array.prototype - .slice.call(obj.toolbarContainerElement - .getElementsByClassName(TOOLBAR_CLASS), 0); + .slice.call(obj.toolbarContainerElement.ownerDocument + .getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0); resizeIframeToWidth(obj.iframe, '4000px', () => { expect(toolbarElements.length).to.be.above(0); toolbars.forEach(toolbar => { @@ -146,8 +146,8 @@ return getToolbars([{}]).then(obj => { const toolbars = obj.toolbars; const toolbarElements = Array.prototype - .slice.call(obj.toolbarContainerElement - .getElementsByClassName(TOOLBAR_CLASS), 0); + .slice.call(obj.toolbarContainerElement.ownerDocument + .getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0); resizeIframeToWidth(obj.iframe, '4000px', () => { expect(toolbarElements.length).to.be.above(0); toolbars.forEach(toolbar => { @@ -164,8 +164,8 @@ return getToolbars([{}]).then(obj => { const toolbars = obj.toolbars; const toolbarElements = Array.prototype - .slice.call(obj.toolbarContainerElement - .getElementsByClassName(TOOLBAR_CLASS), 0); + .slice.call(obj.toolbarContainerElement.ownerDocument + .getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0); resizeIframeToWidth(obj.iframe, '4000px', () => { toolbars.forEach(toolbar => { toolbar.onLayoutChange(); @@ -188,7 +188,7 @@ const toolbars = obj.toolbars; const toolbarElements = Array.prototype .slice.call(obj.toolbarContainerElement.ownerDocument - .getElementsByClassName(TOOLBAR_CLASS), 0); + .getElementsByClassName(TOOLBAR_ELEMENT_CLASS), 0); resizeIframeToWidth(obj.iframe, '1px', () => { expect(toolbarElements.length).to.be.above(0); toolbars.forEach(toolbar => {