From db55230749704e9d60f96ad493595af5ff96f71e Mon Sep 17 00:00:00 2001
From: Jake Fried <samouri@users.noreply.github.com>
Date: Thu, 25 Feb 2021 11:51:02 -0500
Subject: [PATCH] Revert "analytics: bail out for detached targets (#32637)"
 (#32892)

This reverts commit ae4a276d40c422697a8bea8458444270894022e4.
---
 extensions/amp-analytics/0.1/instrumentation.js     | 11 -----------
 .../amp-analytics/0.1/test/test-instrumentation.js  | 13 -------------
 2 files changed, 24 deletions(-)

diff --git a/extensions/amp-analytics/0.1/instrumentation.js b/extensions/amp-analytics/0.1/instrumentation.js
index b1b590a4ce8a..e0cdfa61d3e6 100644
--- a/extensions/amp-analytics/0.1/instrumentation.js
+++ b/extensions/amp-analytics/0.1/instrumentation.js
@@ -24,7 +24,6 @@ import {
 import {AmpdocAnalyticsRoot, EmbedAnalyticsRoot} from './analytics-root';
 import {AnalyticsGroup} from './analytics-group';
 import {Services} from '../../../src/services';
-import {dev} from '../../../src/log';
 import {dict} from '../../../src/utils/object';
 import {getFriendlyIframeEmbedOptional} from '../../../src/iframe-helper';
 import {
@@ -35,7 +34,6 @@ import {
 } from '../../../src/service';
 
 const PROP = '__AMP_AN_ROOT';
-const TAG = 'ANALYTICS-INSTRUMENTATION';
 
 /**
  * @implements {../../../src/service.Disposable}
@@ -104,15 +102,6 @@ export class InstrumentationService {
     vars = dict(),
     enableDataVars = true
   ) {
-    if (!target.isConnected) {
-      dev().error(
-        TAG,
-        'Attempting to trigger event for detached target: %s',
-        target
-      );
-      return;
-    }
-
     const event = new AnalyticsEvent(target, eventType, vars, enableDataVars);
     const root = this.findRoot_(target);
     const trackerName = getTrackerKeyName(eventType);
diff --git a/extensions/amp-analytics/0.1/test/test-instrumentation.js b/extensions/amp-analytics/0.1/test/test-instrumentation.js
index 18dfae326ea7..142bfe74c1ed 100644
--- a/extensions/amp-analytics/0.1/test/test-instrumentation.js
+++ b/extensions/amp-analytics/0.1/test/test-instrumentation.js
@@ -63,19 +63,6 @@ describes.realWin('InstrumentationService', {amp: 1}, (env) => {
     expect(event.type).to.equal('test-event');
     expect(event.vars).to.deep.equal({foo: 'bar'});
   });
-
-  it('should bail and emit error if element is detached', () => {
-    expectAsyncConsoleError(/detached/);
-    const detached = ampdoc.win.document.createElement('div');
-    const tracker = root.getTracker(
-      AnalyticsEventType.CUSTOM,
-      CustomEventTracker
-    );
-    const triggerStub = env.sandbox.stub(tracker, 'trigger');
-    service.triggerEventForTarget(detached, 'test-event');
-
-    expect(triggerStub).not.called;
-  });
 });
 
 describes.realWin(