From e1e266bff6e3ce4bbcdf329857b95fb9d6c2a3b9 Mon Sep 17 00:00:00 2001
From: Jake Fried <samouri@users.noreply.github.com>
Date: Wed, 29 Jan 2020 13:48:06 -0500
Subject: [PATCH] =?UTF-8?q?=F0=9F=95=B5=EF=B8=8F=20Improve=20logging=20to?=
 =?UTF-8?q?=20debug=20missing=20Resource=20issue.=20(#26506)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Improve logging to debug missing Resource issue.

* userAssert --> devAssert

* getMode() --> getMode().runtime

* devAssert --> dev().error

* where did the mode go

* TAG_
---
 src/service/resources-impl.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/service/resources-impl.js b/src/service/resources-impl.js
index fa4320274678..a506764cbac3 100644
--- a/src/service/resources-impl.js
+++ b/src/service/resources-impl.js
@@ -28,6 +28,7 @@ import {closest, hasNextNodeInDocumentOrder} from '../dom';
 import {computedStyle} from '../style';
 import {dev, devAssert} from '../log';
 import {dict} from '../utils/object';
+import {getMode} from '../mode';
 import {getSourceUrl} from '../url';
 import {checkAndFix as ieMediaCheckAndFix} from './ie-media-bug';
 import {isBlockedByConsent, reportError} from '../error';
@@ -624,6 +625,14 @@ export class ResourcesImpl {
         const ampElements = element.getElementsByClassName('i-amphtml-element');
         for (let i = 0; i < ampElements.length; i++) {
           const r = Resource.forElement(ampElements[i]);
+          if (typeof r === 'undefined') {
+            dev().error(
+              TAG_,
+              'AMP Element is missing an associated resource. Element: %s, Runtime: %s',
+              ampElements[i],
+              getMode().runtime
+            );
+          }
           r.requestMeasure();
         }
         if (relayoutTop != -1) {