Navigation Menu

Skip to content

Commit

Permalink
✨ amp-brid-player: set amp param
Browse files Browse the repository at this point in the history
* collapse ad unit on ad end

* height change removed
  • Loading branch information
pedjoni8 authored and aghassemi committed Sep 21, 2018
1 parent 542ab96 commit e434b38
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions extensions/amp-brid-player/0.1/amp-brid-player.js
Expand Up @@ -114,7 +114,7 @@ class AmpBridPlayer extends AMP.BaseElement {
encodeURIComponent(feedType) +
'/' + encodeURIComponent(this.feedID_) +
'/' + encodeURIComponent(this.partnerID_) +
'/' + encodeURIComponent(this.playerID_) + '/0/1';
'/' + encodeURIComponent(this.playerID_) + '/0/1/?amp=1';

this.videoIframeSrc_ = assertAbsoluteHttpOrHttpsUrl(src);

Expand Down Expand Up @@ -162,8 +162,6 @@ class AmpBridPlayer extends AMP.BaseElement {
this.handleBridMessage_.bind(this)
);

this.element.appendChild(iframe);

return this.loadPromise(iframe)
.then(() => this.playerReadyPromise_);
}
Expand Down
Expand Up @@ -70,7 +70,7 @@ describes.realWin('amp-brid-player', {
expect(iframe).to.not.be.null;
expect(iframe.tagName).to.equal('IFRAME');
expect(iframe.src).to.equal(
'https://services.brid.tv/services/iframe/video/13663/264/4144/0/1');
'https://services.brid.tv/services/iframe/video/13663/264/4144/0/1/?amp=1');
});
});

Expand Down

0 comments on commit e434b38

Please sign in to comment.