From e434b3897c3d338f2e00b7b85b676116786a6b3e Mon Sep 17 00:00:00 2001 From: pedjoni8 <32640009+pedjoni8@users.noreply.github.com> Date: Sat, 22 Sep 2018 01:30:39 +0200 Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20amp-brid-player:=20set=20amp=20para?= =?UTF-8?q?m?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * collapse ad unit on ad end * height change removed --- extensions/amp-brid-player/0.1/amp-brid-player.js | 4 +--- extensions/amp-brid-player/0.1/test/test-amp-brid-player.js | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/extensions/amp-brid-player/0.1/amp-brid-player.js b/extensions/amp-brid-player/0.1/amp-brid-player.js index 845d35c7afea..f51bb0b87e50 100644 --- a/extensions/amp-brid-player/0.1/amp-brid-player.js +++ b/extensions/amp-brid-player/0.1/amp-brid-player.js @@ -114,7 +114,7 @@ class AmpBridPlayer extends AMP.BaseElement { encodeURIComponent(feedType) + '/' + encodeURIComponent(this.feedID_) + '/' + encodeURIComponent(this.partnerID_) + - '/' + encodeURIComponent(this.playerID_) + '/0/1'; + '/' + encodeURIComponent(this.playerID_) + '/0/1/?amp=1'; this.videoIframeSrc_ = assertAbsoluteHttpOrHttpsUrl(src); @@ -162,8 +162,6 @@ class AmpBridPlayer extends AMP.BaseElement { this.handleBridMessage_.bind(this) ); - this.element.appendChild(iframe); - return this.loadPromise(iframe) .then(() => this.playerReadyPromise_); } diff --git a/extensions/amp-brid-player/0.1/test/test-amp-brid-player.js b/extensions/amp-brid-player/0.1/test/test-amp-brid-player.js index d088d7ee239e..30f76f52a8e1 100644 --- a/extensions/amp-brid-player/0.1/test/test-amp-brid-player.js +++ b/extensions/amp-brid-player/0.1/test/test-amp-brid-player.js @@ -70,7 +70,7 @@ describes.realWin('amp-brid-player', { expect(iframe).to.not.be.null; expect(iframe.tagName).to.equal('IFRAME'); expect(iframe.src).to.equal( - 'https://services.brid.tv/services/iframe/video/13663/264/4144/0/1'); + 'https://services.brid.tv/services/iframe/video/13663/264/4144/0/1/?amp=1'); }); });