Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-date-picker height is not correct #13897

Open
Jade05 opened this issue Mar 9, 2018 · 6 comments

Comments

@Jade05
Copy link

commented Mar 9, 2018

Environment

windows chrome 63.0.3239.108

Description

issue1

amp-date-picker's height is set with a specific value when it is initialized. But the height isn't enough with some particular months.

@aghassemi

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

/to @cvializ

@cvializ

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2018

This bug occurs because of differences between React and Preact, and there is a race in the react-dates library that causes height adjustment to happen one click late when switching between months. More investigation is needed to resolve. The bug does not occur if React is used instead.

@cvializ

This comment has been minimized.

Copy link
Contributor

commented May 22, 2018

As a workaround, you can set the min-height of the .DayPicker_transitionContainer element with CSS. If you change the day-size attribute you will need to do this.

@Jade05

This comment has been minimized.

Copy link
Author

commented May 23, 2018

thank you for your reply:). We make the date comp fit the full screen finally.

cvializ added a commit that referenced this issue Jun 27, 2018

🐛🖍Add a warning for non-default day-size values due to #13897 (#16423)
* Add a warning for non-default day-size values due to #13897

* Add example for the warning

* Nuance
@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2018

This issue hasn't been updated in awhile. @cvializ Do you have any updates?

@cvializ cvializ added P3: When Possible and removed P2: Soon labels Oct 9, 2018

@cvializ

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2018

Reducing to P3 since the warning and workaround are implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.