Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Default loading state improvement for all components #14064

Open
ericlindley-g opened this Issue Mar 16, 2018 · 2 comments

Comments

@ericlindley-g
Copy link
Collaborator

ericlindley-g commented Mar 16, 2018

Feature description:

AMP has a default loader for most content that depends on an external server call for content. Currently it's an animated ellipsis for most cases, and a more polished design for ads. This feature is to create a more polished design across all components that need it, and to possibly differentiate designs based on the context.

Related issues:

  • Figure out which components use the default loading state.

Related PRs:
/cc @aghassemi can you add relevant PRs when available? (either listing or linking by mentioning this feature in those PRs)

@ericlindley-g ericlindley-g added this to the Prioritized FRs milestone Mar 16, 2018

@ericlindley-g ericlindley-g self-assigned this Mar 16, 2018

@ericlindley-g ericlindley-g added this to Feature Backlog in AMP HTML Project Roadmap via automation Mar 16, 2018

@ericlindley-g ericlindley-g moved this from Feature Backlog to In Progress in AMP HTML Project Roadmap Apr 19, 2018

@cathyxz cathyxz self-assigned this May 10, 2018

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Jun 5, 2018

This issue doesn't have a category which makes it harder for us to keep track of it. @cathyxz Please add an appropriate category.

@ericlindley-g

This comment has been minimized.

Copy link
Collaborator Author

ericlindley-g commented Jul 16, 2018

Related: #16313

@cathyxz cathyxz assigned sparhami and unassigned cathyxz Aug 23, 2018

@ericlindley-g ericlindley-g changed the title [Master feature] Loading state improvement for default for all components [Master feature] Default loading state improvement for all components Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.