New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Easy fade-in-on-scroll #14067

Closed
ericlindley-g opened this Issue Mar 16, 2018 · 2 comments

Comments

2 participants
@ericlindley-g
Collaborator

ericlindley-g commented Mar 16, 2018

Feature description:

amp-position-observer makes it possible to create complex scroll-bound & scroll-triggered animations. However, we want to make some of the most common animations trivially simple to implement. This feature covers the case where arbitrary HTML elements fade in as the user scrolls them into view—both the scroll-bound case and scroll-triggered, time-based case. Developers will be able to configure aspects of the animation like trigger points, timing, and animation curve.

Related issues:
TODO

Related PRs:
/cc @nainar, can you add relevant PRs here?

@ericlindley-g ericlindley-g added this to the Prioritized FRs milestone Mar 16, 2018

@ericlindley-g ericlindley-g self-assigned this Mar 16, 2018

@ericlindley-g ericlindley-g added this to Feature Backlog in AMP HTML Project Roadmap via automation Mar 16, 2018

@ericlindley-g ericlindley-g moved this from Feature Backlog to In Progress in AMP HTML Project Roadmap Mar 16, 2018

This was referenced Apr 16, 2018

@nainar

This comment has been minimized.

Collaborator

nainar commented Apr 27, 2018

PR landed:
amp-fx="fade-in" -> #14351
amp-fx="fade-in-scroll" -> #14454

@nainar

This comment has been minimized.

Collaborator

nainar commented May 16, 2018

The experiments were launched here: #15270.

Only thing remaining is visual tests which are being worked on here: #15240

@nainar nainar closed this May 16, 2018

AMP HTML Project Roadmap automation moved this from In Progress to Done May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment