Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] amp-consent support in amp-story #14538

Closed
rudygalfi opened this Issue Apr 10, 2018 · 7 comments

Comments

@rudygalfi
Copy link
Contributor

rudygalfi commented Apr 10, 2018

Bring the feature described in #13716 into amp-story.

@jasti

This comment has been minimized.

Copy link
Collaborator

jasti commented Apr 11, 2018

  • Optionally block publisher served ads based on consent status #14548
@gmajoulet

This comment has been minimized.

Copy link
Collaborator

gmajoulet commented May 3, 2018

  • <amp-story-consent> component #15062
  • i18n
  • Validator
  • Change to use CSS variables to configure the main color
  • Switch from simple template to htmlFor
@jasti

This comment has been minimized.

Copy link
Collaborator

jasti commented May 4, 2018

@rudygalfi

This comment has been minimized.

Copy link
Contributor Author

rudygalfi commented May 16, 2018

@gmajoulet Can you provide any update on status here and do this step if ready?

@gmajoulet

This comment has been minimized.

Copy link
Collaborator

gmajoulet commented May 23, 2018

The documentation is live here, and I will update this issue as soon as the ampbyexample page is published.

@jeffjose

This comment has been minimized.

Copy link
Collaborator

jeffjose commented Jun 25, 2018

Is there any work pending here?

@gmajoulet

This comment has been minimized.

Copy link
Collaborator

gmajoulet commented Jun 25, 2018

I believe we are feature complete. Closing this ticket.

@gmajoulet gmajoulet closed this Jun 25, 2018

Analytics automation moved this from Needs triage to Done Jun 25, 2018

amp-story automation moved this from UI to Done Jun 25, 2018

AMP HTML Project Roadmap automation moved this from Feature Backlog to Done Jun 25, 2018

Consent Tools automation moved this from To do to Done Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.