Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Improve audio UX for amp-story #15562

Closed
newmuis opened this Issue May 24, 2018 · 2 comments

Comments

@newmuis
Copy link
Collaborator

newmuis commented May 24, 2018

Right now it is unclear which story pages have audio and which do not. We should improve the audio experience by only showing the audio icon when it makes sense (#13652) and adding callouts as necessary.

We can say "this page has no sound" when there is no sound on a given page but the audio icon is shown. We can still unmute the story, and notify the user when it is re-muted:
screen shot 2018-05-24 at 2 27 49 pm

If there is sound, we can simply inform the user that the sound has been turned on/off:
screen shot 2018-05-24 at 2 28 05 pm

@newmuis newmuis added this to the Backlog Bugs milestone May 24, 2018

@newmuis newmuis self-assigned this May 24, 2018

@newmuis newmuis added this to Incoming (Untriaged) in amp-story via automation May 24, 2018

@newmuis newmuis moved this from Incoming (Untriaged) to Media Playback / Performance in amp-story Jun 5, 2018

@newmuis newmuis assigned addieachan and unassigned newmuis Jun 13, 2018

@newmuis newmuis changed the title Improve audio UX for amp-story [Master feature] Improve audio UX for amp-story Jul 2, 2018

@newmuis newmuis added this to Feature Backlog in AMP HTML Project Roadmap via automation Jul 2, 2018

@newmuis newmuis moved this from Media Playback / Performance to Master Features in amp-story Jul 3, 2018

@newmuis newmuis added this to To do in AMP stories roadmap via automation Jul 3, 2018

@newmuis newmuis removed this from Master Features in amp-story Jul 3, 2018

@newmuis newmuis moved this from Not started to In Progress in AMP stories roadmap Jul 3, 2018

@newmuis

This comment has been minimized.

Copy link
Collaborator Author

newmuis commented Aug 22, 2018

@addieachan is this resolved since #16327 is merged?

@addieachan

This comment has been minimized.

Copy link
Contributor

addieachan commented Aug 22, 2018

@newmuis Yes!

@newmuis newmuis closed this Aug 23, 2018

AMP HTML Project Roadmap automation moved this from Next Up to Shipped Aug 23, 2018

AMP stories roadmap automation moved this from In Progress to Done Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.