Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master Feature] Leaner AMP #16745

Open
kristoferbaxter opened this Issue Jul 16, 2018 · 12 comments

Comments

@kristoferbaxter
Copy link
Collaborator

kristoferbaxter commented Jul 16, 2018

Gradually JavaScript payloads for libraries tend to increase in size as features and capabilities are expanded. Occasionally, these increases pass thresholds where devices take a noticeably longer time to parse and evaluate code leading to lower boot up performance.

This Master Feature aims to:

  1. Reduce the size of the primary AMP JS bundle by 50%.
  2. Give greater insight to developers where bundle increases derive from.

Timeline: End of Q4 2018.

Effort Tracking: https://github.com/ampproject/amphtml/projects/45

Q3 Goals

@prateekbh

This comment has been minimized.

Copy link
Member

prateekbh commented Jul 16, 2018

The first effort related to Task#2 to was remove existing polyfill for a module build.
This was done as a part of #16452. Note this is yet to used by AMP pages in production.

@erwinmombay erwinmombay added this to the Pending Triage milestone Aug 21, 2018

@erwinmombay

This comment has been minimized.

Copy link
Member

erwinmombay commented Aug 21, 2018

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

1 similar comment
@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Sep 11, 2018

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@kristoferbaxter

This comment has been minimized.

Copy link
Collaborator Author

kristoferbaxter commented Sep 17, 2018

@jridgewell For item #5, how close are we to shipping layers and removing the older custom elements polyfill?

@erwinmombay For item #1, how close are we to shipping CC Advanced?

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Oct 16, 2018

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

4 similar comments
@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Nov 8, 2018

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Nov 28, 2018

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Jan 9, 2019

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Feb 13, 2019

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@morsssss

This comment has been minimized.

Copy link

morsssss commented Mar 5, 2019

Some folks have been asking about this, and I believe this effort is still underway... can someone provide an update?

@kristoferbaxter

This comment has been minimized.

Copy link
Collaborator Author

kristoferbaxter commented Mar 11, 2019

This effort is still underway, @erwinmombay – can you provide an update here on the progress of Single Pass Compilation?

Single Pass Compilation is the blocking factor for the remainder of the already complete work to land.

@erwinmombay

This comment has been minimized.

Copy link
Member

erwinmombay commented Mar 14, 2019

We're still on a slow roll out for single pass compilation, Im going to target the end of this Month (March 2019). There's no easy way currently for us to verify that everything is good w/o a more comprehensive e2e, and integration tests story (especially for ads and analytics where the issues are prominent).

On a brighter note, I finally figured out how to retrieve all the possible locations where possible obfuscations errors may occur due to JsonObject and TypeDefinitions casting. Working on it this sprint and will bring my findings to the Ads and Analytics team.

/cc @lannka @zhouyx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.