Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master Feature] Leaner AMP #16745

Closed
5 tasks
kristoferbaxter opened this issue Jul 16, 2018 · 12 comments
Closed
5 tasks

[Master Feature] Leaner AMP #16745

kristoferbaxter opened this issue Jul 16, 2018 · 12 comments

Comments

@kristoferbaxter
Copy link
Contributor

kristoferbaxter commented Jul 16, 2018

Gradually JavaScript payloads for libraries tend to increase in size as features and capabilities are expanded. Occasionally, these increases pass thresholds where devices take a noticeably longer time to parse and evaluate code leading to lower boot up performance.

This Master Feature aims to:

  1. Reduce the size of the primary AMP JS bundle by 50%.
  2. Give greater insight to developers where bundle increases derive from.

Timeline: End of Q4 2018.

Effort Tracking: https://github.com/ampproject/amphtml/projects/45

Q3 Goals

@prateekbh
Copy link
Member

The first effort related to Task#2 to was remove existing polyfill for a module build.
This was done as a part of #16452. Note this is yet to used by AMP pages in production.

@erwinmombay
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

1 similar comment
@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@kristoferbaxter
Copy link
Contributor Author

@jridgewell For item #5, how close are we to shipping layers and removing the older custom elements polyfill?

@erwinmombay For item #1, how close are we to shipping CC Advanced?

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

4 similar comments
@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @kristoferbaxter Do you have any updates?

@morsssss
Copy link
Contributor

morsssss commented Mar 5, 2019

Some folks have been asking about this, and I believe this effort is still underway... can someone provide an update?

@kristoferbaxter
Copy link
Contributor Author

This effort is still underway, @erwinmombay – can you provide an update here on the progress of Single Pass Compilation?

Single Pass Compilation is the blocking factor for the remainder of the already complete work to land.

@erwinmombay
Copy link
Member

We're still on a slow roll out for single pass compilation, Im going to target the end of this Month (March 2019). There's no easy way currently for us to verify that everything is good w/o a more comprehensive e2e, and integration tests story (especially for ads and analytics where the issues are prominent).

On a brighter note, I finally figured out how to retrieve all the possible locations where possible obfuscations errors may occur due to JsonObject and TypeDefinitions casting. Working on it this sprint and will bring my findings to the Ads and Analytics team.

/cc @lannka @zhouyx

@prateekbh prateekbh removed their assignment Aug 5, 2019
AMP HTML Project Roadmap automation moved this from Next Up to Shipped Jan 15, 2021
Build Size automation moved this from In progress to Done Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Build Size
  
Done
Development

No branches or pull requests

7 participants