Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master Feature] Allow ads to be position fixed on desktop canoncial #18123

Open
bjalford opened this Issue Sep 18, 2018 · 5 comments

Comments

@bjalford
Copy link

bjalford commented Sep 18, 2018

We have a requirement to make an ad sticky in an article template for a publisher in the right hand column on desktop (AMP as canonical). If we add a position fixed the ad doesn't render.

In the same way the amp-sticky-ad has a height restriction, could amp-ads on desktop (or media query great than x pixels) that are position fixed have a max width. Our specific requirement is to render MPUs and double MPUs (300 wide).

@zhouyx

This comment has been minimized.

Copy link
Collaborator

zhouyx commented Sep 19, 2018

to @jasti Regarding how sticky ad works on desktop.

@bjalford that's right, AMP won't render an ad if it is position fixed unless it is positioned inside flying-carpet/lightbox/sticky-ad container.
The request here is to have the sticky-ad sticky to the side of the page (rather than bottom) on desktop? And then maybe a max width restriction can be applied.

@bjalford

This comment has been minimized.

Copy link
Author

bjalford commented Sep 20, 2018

@zhouyx correct. My exact requirements would be for it to be inside a sidebar container (max-width) and be the bottom item inside that container which would then stick.

Example can be seen here: https://www.independent.co.uk/news/uk/home-news/northern-ireland-abortion-pill-mother-prosecuted-daughter-belfast-court-a8546936.html

  • Under 'Popular Videos' an ad (JS DFP) is rendering which we then stick as the user scrolls down the page
@jasti

This comment has been minimized.

Copy link
Collaborator

jasti commented Sep 20, 2018

@bjalford unfortunately large sticky ads on desktop are not approved by the better ads standard as a good ad/ user experience, so we have had to limit the height of the sticky ad on both desktop & mobile. https://www.betterads.org/desktop-large-sticky-ad/

@zhouyx

This comment has been minimized.

Copy link
Collaborator

zhouyx commented Sep 21, 2018

@bjalford As Vamsee said. Large sticky ads on desktop is not something we are planning to build for better ad/user experience. Close as not intent to implement.

@zhouyx zhouyx closed this Sep 21, 2018

@jasti jasti reopened this Oct 15, 2018

@jasti

This comment has been minimized.

Copy link
Collaborator

jasti commented Oct 15, 2018

Reopening this after more research. We'll look into supporting this since
a) This is referring to the sticky ad being in the right or left rail in a fixed position in the desktop view
b) It doesn't obstruct content and is not simply a larger version of the current sticky ad on mobile

@jasti jasti changed the title [FR] allow ads to be position fixed on desktop canoncial [Master Feature] Allow ads to be position fixed on desktop canoncial Oct 15, 2018

@jasti jasti added this to Next Up in AMP HTML Project Roadmap Oct 15, 2018

@ampprojectbot ampprojectbot added this to the New FRs milestone Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.