Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding other extensions when an extension is present #21723

Open
zhouyx opened this issue Apr 4, 2019 · 9 comments
Open

Excluding other extensions when an extension is present #21723

zhouyx opened this issue Apr 4, 2019 · 9 comments

Comments

@zhouyx
Copy link
Contributor

zhouyx commented Apr 4, 2019

Right now we have some extensions that don't work well together. For example when <amp-skimlink> and <amp-link-rewrite> works together, the ladder component can affect what the previous component does.
It would be useful to have a feature that only allow one component on a page among a list of mutual exclusive extensions.

@ampproject/wg-caching

@honeybadgerdontcare
Copy link
Contributor

When discussing this I was thinking of requires_extension and that perhaps we should also have a excludes_extension feature. This is to be more explicit than satisfies, requires and excludes.

@zhouyx
Copy link
Contributor Author

zhouyx commented Apr 4, 2019

I agree. excludes_extensions is also much easier to understand : )

@jpettitt
Copy link
Contributor

jpettitt commented Apr 8, 2019

+1 for excludes_extensions

amp-access and amp-subscriptions are mutually exclusive.

@Gregable
Copy link
Member

@zhouyx I think this got forgotten. Is this still important to you?

@zhouyx
Copy link
Contributor Author

zhouyx commented Jan 14, 2020

I think the issue still exist. But I not urgent because there's no incentive for one to include two components either from different service provider (amp-skimlink vs amp-smartlink) or designed for the same purpose (amp-access vs amp-subscriptions).

@Gregable
Copy link
Member

Thanks for the update. I'll keep it around, but let it remain at P3 for now. Would be nice for a fixit.

@stale
Copy link

stale bot commented Jul 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jul 7, 2021
@Gregable Gregable removed the Stale Inactive for one year or more label Jul 13, 2021
@honeybadgerdontcare
Copy link
Contributor

Is anyone still interested in this being done?

@stale
Copy link

stale bot commented Oct 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Oct 19, 2022
@Gregable Gregable removed their assignment May 30, 2023
@stale stale bot removed the Stale Inactive for one year or more label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants