Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Validator Chrome extension to show debug icon instead of error when in dev mode #24176

Open
westonruter opened this issue Aug 23, 2019 · 2 comments

Comments

@westonruter
Copy link
Member

commented Aug 23, 2019

In #20974 a new data-ampdevmode attribute was added which tells the validator to suppress reporting validation errors for elements it appears on, except for the root html element:

image

In such case, however, when there is only one validation error and it is due to being in debug mode, it would be very useful if the Validator extension would not show an error icon but rather a debug icon, similar to how it shows a warning icon when there are deprecation issues.

If there are other validation errors other than the one data-ampdevmode on the root html element, then the Validator extension should continue to show the error icon.

By showing a debug icon, users won't get alarmed when the system is generating markup that is explicitly invalid for dev mode purposes.

Originally suggested in #20974 (comment).

@westonruter

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

@honeybadgerdontcare When do you think this will be implemented? We're planning to release the next version of the WordPress AMP plugin in a couple weeks and it will have support for dev mode. We'll want to include an explanation of this mode and what users can expect when using the AMP validator extension. So having a sense of timing will help.

@honeybadgerdontcare

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

I have no timeline for implementing this, there are other high priority items I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.