Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
AMP should respect ⚡️ apart from ⚡ #25990
'⚡️'.length; // 2 '⚡'.length; // 1 '⚡'.charCodeAt(0) + ' ' + '⚡'.charCodeAt(1); // "9889 NaN" '⚡️'.charCodeAt(0) + ' ' + '⚡️'.charCodeAt(1); // "9889 65039"
AMP respects the ⚡but rejects
To avoid this confusion, AMP could potentially allow for both,
More background on this bug: https://blog.tomayac.com/2019/12/12/same-same-but-different-unicode-variation-selector-16/.
I'm a fan.
It would probably be best to accept all variants of the lightning bolt instead of just two of them. That could involved either checking against all 16 possibilities or normalizing the attributes by removing all variant selectors (at least for the purpose of the bolt check).