-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect height of amp-consent when navigation bar is displayed #28133
Comments
Hi @MaximePlancke I am unable to reproduce the error with the website you linked. Would you be able to make a gif of the error and post it here? |
Hi @micajuine-ho , FYI, the action buttons are in a sticky footer which is fixed to the bottom of the Iframe. If you check the height of the Iframe you will see that around 20% of the bottom is hidden. Don't hesitate if you need more information. |
Hi @MaximePlancke, I have tried to reproduce with safari and an iphone 8 to no avail. Do you notice anything wrong with this? |
Hi @micajuine-ho , The Safari responsive mode doesn't properly simulate a real device and the behavior is not 100% accurate. (Example: no navigation bar here). You need to test with Xcode using a simulator or with a real device to be able to see the issue. |
Related to #20100. |
@MaximePlancke Thanks for your help! I'm able to repro the issue now. I will update when I make progress.
|
What's the issue?
amp-consent
is loading an Iframe which takes 100vh when the full screen mode is activated. This 100vh includes the navigation bars on iOS devices and some Android which doesn't let the user scroll down to the bottom of the Iframe. It is a problem for us as we have our action buttons inaccessible. Instead of using 100vh, could you make sure the Iframe takes 100% of the visible height?A working solution would be to remove the
height: 100vh
and addIt is a blocking issue on our side. Thank you.
How do we reproduce the issue?
https://sandbox.didomi.io/amp.html
Don't scroll the page, click on Learn More and try to scroll down. You won't be able to reach the bottom buttons.
What browsers are affected?
This example is on an iPhone 8 with iOS 13.4 on Safari but you can find this issue on a lot of iOS devices.
Which AMP version is affected?
2004240001480
The text was updated successfully, but these errors were encountered: