Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毃 Error: ShadowRoot is not defined #28220

Closed
ampprojectbot opened this issue May 5, 2020 · 6 comments 路 Fixed by #28268
Closed

馃毃 Error: ShadowRoot is not defined #28220

ampprojectbot opened this issue May 5, 2020 · 6 comments 路 Fixed by #28268
Assignees
Labels

Comments

@ampprojectbot
Copy link
Member

@ampprojectbot ampprojectbot commented May 5, 2020

Details

Error report: link
First seen: Apr 30, 2020
Frequency: ~ 248/day

Stacktrace

Error: ShadowRoot is not defined
    at ShadowRoot (https://raw.githubusercontent.com/ampproject/amphtml/2005020055000/extensions/amp-analytics/0.1/linker-manager.js:237:26)
    at isLegacyOptIn_ (https://raw.githubusercontent.com/ampproject/amphtml/2005020055000/extensions/amp-analytics/0.1/linker-manager.js:161:15)
    at processConfig_ (https://raw.githubusercontent.com/ampproject/amphtml/2005020055000/extensions/amp-analytics/0.1/linker-manager.js:93:19)
    at init (https://raw.githubusercontent.com/ampproject/amphtml/2005020055000/extensions/amp-analytics/0.1/amp-analytics.js:584:6)
    at linkerTask (https://raw.githubusercontent.com/ampproject/amphtml/2005020055000/extensions/amp-analytics/0.1/amp-analytics.js:589:6)

Notes

@lannka modified extensions/amp-analytics/0.1/linker-manager.js:161-161 in #18029 (Sep 13, 2018)
@rsimha modified extensions/amp-analytics/0.1/linker-manager.js:93-95 in #21212 (May 16, 2019)
@zhouyx modified extensions/amp-analytics/0.1/amp-analytics.js:583-585 in #27605 (Apr 20, 2020)
@zhouyx modified extensions/amp-analytics/0.1/amp-analytics.js:587-590 in #27605 (Apr 20, 2020)

Seen in:

  • 05-02 Nightly (0055)
  • 05-05 Nightly (0322)

Possible assignees: @zhouyx, @lannka

/cc @ampproject/release-on-duty

@ampprojectbot ampprojectbot added the Type: Error Report label May 5, 2020
@rcebulko
Copy link
Contributor

@rcebulko rcebulko commented May 6, 2020

/cc @zhouyx

@micajuine-ho
Copy link
Contributor

@micajuine-ho micajuine-ho commented May 6, 2020

Seems like it could be related to #26683

@zhouyx
Copy link
Contributor

@zhouyx zhouyx commented May 7, 2020

Thanks for the info. I agree, looks related to #26683.
However #26683 was merged a few months ago, I wonder why it leads to the error only recently.

@zhouyx
Copy link
Contributor

@zhouyx zhouyx commented May 7, 2020

@rcebulko I saw the First seen date is : Apr 30, 2020,
but also:
05-02 Nightly (0055)
05-05 Nightly (0322)

Could you clarify when the error first occurred? I wonder if this is also related to #28069
Is this a canary only error?

@zhouyx zhouyx self-assigned this May 7, 2020
@rcebulko
Copy link
Contributor

@rcebulko rcebulko commented May 7, 2020

@zhouyx It appears this is probably an error that appeared in some similar form on April 30 for an unrelated reason, but then something in 05-02 Nightly (0055) introduced a similar error that Stackdriver grouped together based on the stacktrace. The graph of occurrences over the last week is below:

image

It seems to have started in earnest on 05-04, and the Apr 30 date may have been noise

@zhouyx
Copy link
Contributor

@zhouyx zhouyx commented May 8, 2020

Thank you @rcebulko. In that case I'm certain that the error is related to the analytics-chunks experiment we are running in canary.

However I don't have any idea on what's causing the error. I've created #28268 that can remove the ShadowRoot check entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants