Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp-story-player] Provide page attachment state #29219

Closed
Enriqe opened this issue Jul 9, 2020 · 2 comments
Closed

[amp-story-player] Provide page attachment state #29219

Enriqe opened this issue Jul 9, 2020 · 2 comments
Assignees
@Enriqe
Labels
P2: Soon Type: Bug WG: stories

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Jul 9, 2020 •
edited
Loading

We should fire an event / getter for the story states, so developers can know when the page attachment is open/closed.

Related to #28416
@Enriqe Enriqe self-assigned this Jul 9, 2020
@Enriqe Enriqe added the P2: Soon label Jul 9, 2020
@Enriqe Enriqe mentioned this issue Jul 9, 2020
Merged
@gmajoulet
Copy link
Contributor

To be more future proof, I think we should open the access to the getState/setState API as a whole.

cc @ampproject/wg-stories

@Enriqe Enriqe mentioned this issue Jul 17, 2020
Merged
@connielei connielei mentioned this issue Jul 17, 2020
Merged
@Enriqe
Copy link
Contributor Author

Enriqe commented Aug 4, 2020

Closed by #29345

@Enriqe Enriqe closed this as completed Aug 4, 2020
@gmajoulet gmajoulet mentioned this issue Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enriqe Enriqe

Labels
P2: Soon Type: Bug WG: stories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmajoulet @Enriqe