Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Animation presets] Desktop panels mode, start animations after page transition #29753

Closed
processprocess opened this issue Aug 7, 2020 · 6 comments

Comments

@processprocess
Copy link
Contributor

Animations currently play while the desktop panel is transitioning.
They should start after the page is done transitioning.

cc @ampproject/wg-stories @hongwei1990

@processprocess processprocess added this to To do in wg-stories Animation via automation Aug 7, 2020
@processprocess processprocess changed the title [Animation presets] Desktop panels mode, start animations after page transition. [Animation presets] Desktop panels mode, start animations after page transition Aug 7, 2020
@gmajoulet
Copy link
Contributor

gmajoulet commented Aug 7, 2020

It's a bit tricky because we do want videos to start playing as soon as the transition starts, otherwise you get gaps in playback/audio.
The animations could potentially be synchronized with the videos, and they'd get out of sync if we delay them.

It's a bigger conversation, but because of this and other multi-page animations issues, I think we should start considering killing the desktop panels carousel animation.

@processprocess
Copy link
Contributor Author

There might be a different kind of transition that still gives the user a hint that the page moved and where it came from
but doesn't require the entire movement.

@gmajoulet
Copy link
Contributor

Ooooh that's extremely interesting! What do you have in mind?

@processprocess
Copy link
Contributor Author

Something that involves not animating the active page but subtly animating the inactive pages, hinting that they used to be in the active state.
I think the tricky part will be to not draw attention to the inactive pages when they animate.

@samitron7
Copy link

What about just capturing the page position (ie center of viewport) and play animation only when the page is located in center of viewport. So the video can still start as soon as the page transition starts but animation only plays when the page is in the center (unless I'm not seeing any other video considerations).

@processprocess
Copy link
Contributor Author

This has been resolved as part of #35267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants