Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story Player] Swipe animation appears to be broken on some integrations #31193

Closed
gmajoulet opened this issue Nov 16, 2020 · 6 comments
Closed

Comments

@gmajoulet
Copy link
Contributor

See here: https://h8ufz.csb.app/

  1. Swipe to navigate forward only translates the next story. On touch release the current story flies away super fast
  2. Swipe to navigate backward has no touch feedback (Story doesn't follow the finger). On touch release the two stories appear to be overlapping once they animate

cc @ampproject/wg-stories

@gmajoulet gmajoulet added this to To do (Needs Triaging) in wg-stories Player via automation Nov 16, 2020
@gmajoulet gmajoulet added this to To do in wg-stories Sprint via automation Nov 16, 2020
@gmajoulet gmajoulet moved this from To do (Needs Triaging) to Bugs in wg-stories Player Nov 16, 2020
@Enriqe
Copy link
Contributor

Enriqe commented Nov 16, 2020

@edoudou I'm having trouble debugging this, could you share the JS code that you used in this sample for the player please?

@gmajoulet
Copy link
Contributor Author

Have you tried starting with an empty configuration and then using add() and show()?

@Enriqe
Copy link
Contributor

Enriqe commented Nov 16, 2020

Yep

@edoudou
Copy link
Contributor

edoudou commented Nov 16, 2020

I'm trying to find a way to send you a public sample of my code but tbh it doesn't seems to have the same comportement.

It may have something to do with the fact that in my component i am inside a web component (with shadow root) ?

I'll try to have something working for you.

@Enriqe
Copy link
Contributor

Enriqe commented Feb 10, 2021

@edoudou are you still seeing this, or is this good to close?

@Enriqe Enriqe assigned gmajoulet and unassigned Enriqe Jun 8, 2021
@gmajoulet
Copy link
Contributor Author

@edoudou please re-open if you're still experiencing this. We changed so much in the Player code and the way things are positioned / transitioned that the issue is likely gone.

wg-stories Player automation moved this from Bugs to Done Aug 5, 2021
wg-stories Sprint automation moved this from To do to Done Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants