New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a flying carpet visual effect for AMP - applicable to any amp-element in general but specifically for Ads #3126

Closed
kashyapnitin opened this Issue May 6, 2016 · 2 comments

Comments

Projects
None yet
5 participants
@kashyapnitin

kashyapnitin commented May 6, 2016

Primary objective:
Allow publishers to be able to show as flying carpets
Illustrative (but not necessarily final mock) here
fc-mock

Secondary objective:
Make it really easy in AMP to give the same visual treatment

Rationale:

  • It’s a nice visual format
  • It’s traditionally not easy to do and would require special treatments / JS in the creative itself
  • AMP can make it really easy to give this treatment to any amp-element not just ads, and do so in a performance compliant way
  • It is also principally not against any of AMP rules around knowing size and placement of amp-elements in advance
  • It can be a good differentiator / pull factor for amp pages
  • When used for ads it is likely to generate higher viewability and CTRs (To be verified)

Requirements:

  • Publisher should be able to specify that they want AMP runtime to render / layout an or any eligible using the flying carpet layout
  • Publisher should be able to pass in an any additional information needed to render / layout the given amp-element as a flying carpet - such as max size of the flying carpet, its position in the page and its position relative to the viewport (when the flying carpet is fully visible)
  • Clicks, taps and swipes etc. within the flying carpet window should work as expected
  • The flying carpet window should never be larger than the device viewport
  • The element that is shown within the flying carpet window is always center aligned
@ericlindley-g

This comment has been minimized.

Show comment
Hide comment
@ericlindley-g

ericlindley-g May 9, 2016

Collaborator

@jridgewell , passing to you (feel free to correct if you're not the primary Eng owner)—do you have a milestone target for this? (will put in "pending..." for now)

Collaborator

ericlindley-g commented May 9, 2016

@jridgewell , passing to you (feel free to correct if you're not the primary Eng owner)—do you have a milestone target for this? (will put in "pending..." for now)

@rudygalfi rudygalfi modified the milestones: Sprint: 2016-05-12, Pending Sprint Slotting May 11, 2016

@dvoytenko dvoytenko modified the milestone: Sprint: 2016-05-12 May 23, 2016

@rudygalfi rudygalfi modified the milestone: Sprint: 2016-05-26 May 23, 2016

@jridgewell

This comment has been minimized.

Show comment
Hide comment
@jridgewell

jridgewell Jun 7, 2016

Member

Closed by #3118.

Member

jridgewell commented Jun 7, 2016

Closed by #3118.

@jridgewell jridgewell closed this Jun 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment