Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move building outlink attachment to layoutcallback. #34924

Merged
merged 4 commits into from Jun 25, 2021
Merged

Move building outlink attachment to layoutcallback. #34924

merged 4 commits into from Jun 25, 2021

Conversation

processprocess
Copy link
Contributor

@processprocess processprocess commented Jun 18, 2021 •
edited

Moves the building of the outlink preview to layoutCallback.

This element for reference:
Screen Shot 2021-06-18 at 2 20 07 PM

@processprocess processprocess self-assigned this Jun 18, 2021
@processprocess processprocess added this to In progress in wg-stories Sprint via automation Jun 18, 2021
@processprocess processprocess added this to In progress in wg-stories Page attachments via automation Jun 18, 2021
@processprocess processprocess marked this pull request as ready for review June 18, 2021 18:40
@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page-attachment.js

@gmajoulet
Copy link
Contributor

(I'll let you click merge, but it'd be awesome if we could get this in before tomorrow end of day)

@processprocess processprocess merged commit 5ff62ec into ampproject:main Jun 25, 2021
wg-stories Sprint automation moved this from In progress to Done Jun 25, 2021
wg-stories Page attachments automation moved this from In progress to Done Jun 25, 2021
@processprocess processprocess deleted the layout-outlink branch June 25, 2021 14:57
antiphoton pushed a commit to antiphoton/amphtml that referenced this pull request Jun 25, 2021
@processprocess @antiphoton
Move building outlink attachment to layoutcallback. (ampproject#34924)
f858ea1 
* Move building outlink attachment to layoutcallback.

* Only build in layoutCallback if experiment is on.

* Check experiment.

* Add comment.
@processprocess processprocess mentioned this pull request Jul 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

@newmuis newmuis Awaiting requested review from newmuis

Assignees

@processprocess processprocess

Labels
P1: High Priority WG: stories
Projects
wg-stories Page attachments
Done
wg-stories Sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@processprocess @gmajoulet