Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-story-page-outlink default value for cta-accent-color attribute #34983

Closed
processprocess opened this issue Jun 23, 2021 · 0 comments · Fixed by #35866
Closed

amp-story-page-outlink default value for cta-accent-color attribute #34983

processprocess opened this issue Jun 23, 2021 · 0 comments · Fixed by #35866
Assignees
@processprocess
Labels
P2: Soon Type: Feature Request WG: stories

Comments

@processprocess
Copy link
Contributor

processprocess commented Jun 23, 2021 •
edited
Loading

Description

When theme="custom" is specified without a cta-accent-color value, color values are null and this is the result:
Screen Shot 2021-06-23 at 10 27 03 AM

We could give default values to the css variables and throw a warning.
Screen Shot 2021-06-23 at 10 29 18 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@processprocess processprocess

Labels
P2: Soon Type: Feature Request WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 [Amp story page outlink] Default outlink color and warning processprocess/amphtml
1 participant
@processprocess