Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-story-desktop-one-panelbackground-blur Include videos in selector #35131

Closed
processprocess opened this issue Jul 7, 2021 · 0 comments · Fixed by #35231
Closed

amp-story-desktop-one-panelbackground-blur Include videos in selector #35131

processprocess opened this issue Jul 7, 2021 · 0 comments · Fixed by #35231

Comments

@processprocess
Copy link
Contributor

processprocess commented Jul 7, 2021

Description

Many story pages feature full bleed video but no image or an icon.
In these cases the background-blur does not render an image, or renders the icon.

Instead, it could render the first frame of the video by including it in the selector.

Sketch PR

This needs to save a reference to the first frame of the video and only render that one frame.
Otherwise the background will render the current frame of the video element while in transitions in and the background will move.

Some tests:
https://user-images.githubusercontent.com/3860311/124760294-98b52580-defe-11eb-8068-e4520213cf5b.mp4
https://user-images.githubusercontent.com/3860311/124760698-ffd2da00-defe-11eb-8628-1aec5c84f5fc.mp4

Alternatives Considered

Instead of rendering the first video frame it could keep rendering video:
https://user-images.githubusercontent.com/3860311/124760488-cd28e180-defe-11eb-949e-4e5abe32d881.mp4
This appears distracting and may use up unnecessary resources.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment