Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP Story Docs] Animation information hard to find #35398

alankent opened this issue Jul 26, 2021 · 0 comments · Fixed by #35489

[AMP Story Docs] Animation information hard to find #35398

alankent opened this issue Jul 26, 2021 · 0 comments · Fixed by #35489


Copy link

alankent commented Jul 26, 2021

[UPDATED: July 28 - I removed some erroneous assumptions about there being an animation trigger that fires when a video finishes playing in amp-video.]

I went to amp-story-page looking for animation, but there was no mention of animation anywhere on page. I went to amp-story and it does contain an animation section talking about what you can do on amp-story-page elements. This felt strange (animation did mention amp-story-page, but that page does not mention animation at all).

amp-story also referenced amp-story-animation for advanced animation, which is not shown in the list of elements under the "web stories" list of components in the docs.

This suggestion is to

  • Add a reference on the amp-story-page web component page to the amp-story page regarding animation
  • Consider whether amp-story-animation should be added to the list of documented components on the site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging a pull request may close this issue.

2 participants