Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story video] Add codec information received from video cache #36228

Closed
gmajoulet opened this issue Sep 30, 2021 · 1 comment · Fixed by #36224
Closed

[Story video] Add codec information received from video cache #36228

gmajoulet opened this issue Sep 30, 2021 · 1 comment · Fixed by #36224

Comments

@gmajoulet
Copy link
Contributor

Description

Add codec information received from video cache.

The type parameter should include the codecs, e.g. type="video/mp4;codecs=vp9", from the JSON response we receive:

"sources":  [
    {
      "url": "url",
      "codec": "h264",
      "type": "video/mp4",
      "bitrate_kbps": 400
    },
    {
      "url": "url",
      "codec": "vp09.00.21.08",
      "type": "video/mp4",
      "bitrate_kbps": 276
    }
  ],

'type': source['type'],

cc @ampproject/wg-stories

Alternatives Considered

Additional Context

No response

@gmajoulet
Copy link
Contributor Author

cc @coreymasanto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant