Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] storyContentLoaded event doesn't fire when loading story on page index != 0 #36571

Closed
gmajoulet opened this issue Oct 26, 2021 · 2 comments · Fixed by #36307
Closed

Comments

@gmajoulet
Copy link
Contributor

Description

storyContentLoaded event doesn't fire when loading story on page index different than 0.

Reproduction Steps

Navigate to any page, refresh the Story which will load on the same page, the storyContentLoaded doesn't fire.

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

@gmajoulet
Copy link
Contributor Author

cc @ampproject/wg-stories

@mszylkowski
Copy link
Contributor

What probably happened is that whenInitialContentLoaded waited for this.pages[0] it would never resolve until you navigated page 0 of the story. After the PR linked below, we wait for the initial active page (which might come from the history or hashParam) so that the event is fired regardless of the initial page loaded.

I assume that this behavior was found on stable and not on nightly since we recently fixed it on #36307 so it should be safe to close (in a few days the fix will be in stable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants