Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp story shopping] Add Object typedef for shopping data #36911

Closed
processprocess opened this issue Nov 12, 2021 · 2 comments · Fixed by #36757
Closed

[amp story shopping] Add Object typedef for shopping data #36911

processprocess opened this issue Nov 12, 2021 · 2 comments · Fixed by #36757

Comments

@processprocess
Copy link
Contributor

processprocess commented Nov 12, 2021

Description

A typedef for SHOPPING_DATA will help developers/reviewers understand the code.

Check out the example for interactives in component in store service here and here.

This is a follow up to this comment.

@jshamble
Copy link
Contributor

Closing this as I am solving it in #36699

wg-stories Shopping automation moved this from To do to Done Nov 13, 2021
@processprocess
Copy link
Contributor Author

processprocess commented Nov 15, 2021

Re opening this.
Please do not close issues before they are merged.
Please add "Closes #36911" to the description of #36757 that way it will automatically be closed when that PR is merged.

wg-stories Shopping automation moved this from Done to In progress Nov 15, 2021
wg-stories Shopping automation moved this from In progress to Done Nov 18, 2021
@processprocess processprocess added this to To do in wg-stories Sprint via automation Nov 18, 2021
@processprocess processprocess moved this from To do to Done in wg-stories Sprint Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants