Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I2R] amp-video cache through amp-orig-src #37425

Open
gmajoulet opened this issue Jan 19, 2022 · 1 comment
Open

[I2R] amp-video cache through amp-orig-src #37425

gmajoulet opened this issue Jan 19, 2022 · 1 comment
Assignees
@mszylkowski
Labels
Component: amp-video & interface amp-video and video interface/manager INTENT TO REMOVE Proposes removing a deprecated AMP feature. Use after the INTENT TO DEPRECATE. P3: When Possible WG: caching WG: stories

Comments

@gmajoulet
Copy link
Contributor

Summary

The new amp-video[cache=*] completely replaced the `amp-video src="" amp-orig-src="" mechanism.

This attribute is NOT valid AMPHTML, so we should be able to safely remove the unused code from amp-video.

Intent-to-Deprecate (I2D) Issue

Rollout Plan

Has not been used for many months, and is not valid AMP.

Alternative Implementation

Additional Context

No response

Notifications

/cc @ampproject/wg-approvers @ampproject/wg-stories
@gmajoulet gmajoulet added the INTENT TO REMOVE Proposes removing a deprecated AMP feature. Use after the INTENT TO DEPRECATE. label Jan 19, 2022
@mszylkowski mszylkowski mentioned this issue Feb 2, 2022
Closed
@jshamble jshamble mentioned this issue Apr 8, 2022
Open
@jshamble jshamble mentioned this issue May 20, 2022
Open
@stale
Copy link

stale bot commented Jan 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jan 21, 2023
@stale stale bot removed the Stale Inactive for one year or more label Aug 22, 2023
@erwinmombay erwinmombay added WG: stories Component: amp-video & interface amp-video and video interface/manager Stale Inactive for one year or more labels Aug 22, 2023
@stale stale bot removed Stale Inactive for one year or more labels Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mszylkowski mszylkowski

Labels
Component: amp-video & interface amp-video and video interface/manager INTENT TO REMOVE Proposes removing a deprecated AMP feature. Use after the INTENT TO DEPRECATE. P3: When Possible WG: caching WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🚮 [Story video] Remove amp orig src mszylkowski/amphtml
4 participants
@erwinmombay @gmajoulet @banaag @mszylkowski