Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@bentoproject/core broken in React component #37919

Closed
swissspidy opened this issue Mar 19, 2022 · 0 comments
Closed

@bentoproject/core broken in React component #37919

swissspidy opened this issue Mar 19, 2022 · 0 comments

Comments

@swissspidy
Copy link
Contributor

swissspidy commented Mar 19, 2022

Description

This is a follow-up to the effort in #37546 with related PRs #37645, #37734

We noticed that the React version of components like @bentoproject/base-carousel is currently broken, with errors in @bentoproject/core.

The versions before #37546 are not affected, though they have another bug.

The last stable React version of @bentoproject/base-carousel I can currently use is from December.

Needless to say, some more tests for the React versions would help prevent such regressions in the future

Reproduction Steps

Try using the React version @bentoproject/base-carousel / rendering <BentoBaseCarousel> and notice

Relevant Logs

TypeError: Cannot read properties of undefined (reading '__H')
    at Gt (bento.core.module.js:formatted:2514:NaN)
    at Yt (bento.core.module.js:formatted:2514:NaN)
    at bento.core.module.js:formatted:2514:NaN

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

2203041950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant