Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp story page attachment] CTA is not tab-able #37933

Closed
processprocess opened this issue Mar 22, 2022 · 0 comments · Fixed by #37936
Closed

[amp story page attachment] CTA is not tab-able #37933

processprocess opened this issue Mar 22, 2022 · 0 comments · Fixed by #37936

Comments

@processprocess
Copy link
Contributor

processprocess commented Mar 22, 2022

Description

Inline attachment CTAs are currently not tab-able.
This breaks keyboard a11y.

A couple approaches to making it visible to the a11y dom tree:

  1. Adding an empty href attribute.
  2. Changing it to a button instead of an anchor element.

Screen Shot 2022-03-22 at 10 50 52 AM

Reproduction Steps

  1. Open a story with an attachment such as examples/amp-story/attachment.html on the dev server.
  2. press tab to cycle through tab-able elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment