Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In standalone mode use target="_blank" on anchors to external pages #3861

Closed
sebastianbenz opened this issue Jul 1, 2016 · 2 comments · Fixed by #23844

Comments

@sebastianbenz
Copy link
Collaborator

commented Jul 1, 2016

Automatically open anchors to external pages with target="_blank" in Chrome on Android. This avoids getting stuck in the external page on devices without native back button:

if (window.matchMedia('(display-mode: standalone)').matches) {
  // open all links to external pages in a new window
}

source

On mobile safari this happens automatically (there we have the opposite problem #3835).

How do we reproduce the issue?

  1. Mobile Chrome: add https://amp-by-example-staging.appspot.com to the home screen
  2. Launch from the home screen.
  3. Open a link to Github

=> The Github link opens in standalone mode. On devices without native back button (kindle fire) this means you're stuck on Github and can't get back to the web app.

What browsers are affected?

Chrome on Android

//cc @andreban @PaulKinlan

@mkhatib mkhatib added this to the Next milestone Jul 2, 2016

@mkhatib

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

Thanks for investigating these and filing with detailed description! This sounds good to me.

@ampprojectbot

This comment has been minimized.

Copy link
Member

commented Oct 20, 2017

This issue seems to be in Pending Triage for awhile. @aghassemi Please triage this to an appropriate milestone.

@aghassemi aghassemi modified the milestones: Pending Triage, New FRs Oct 23, 2017

@aghassemi aghassemi removed their assignment Jun 21, 2019

@aghassemi aghassemi added this to Navigation in UI - Component Jun 21, 2019

@nainar nainar added this to Backlog in UI - FixIt via automation Aug 5, 2019

@nainar nainar moved this from Backlog to Candidates in UI - FixIt Aug 6, 2019

@cvializ cvializ self-assigned this Aug 8, 2019

UI - FixIt automation moved this from Candidates to Done Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.