New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Punch List] - Lightbox 2.0 #4152

Closed
aghassemi opened this Issue Jul 21, 2016 · 4 comments

Comments

@aghassemi
Member

aghassemi commented Jul 21, 2016

This is a tracker issue for related work planned for lightbox enhancements in AMP.

  • Define a JavaScript interface for lightboxable. Any AMP or DOM element implementing this interface will become lightboxable and a candidate for discovery for auto-lightboxing. This contact defines exactly what properties and functionality elements need to provide to be lightboxable. (e.g. thumbnail, description, etc.. )
  • Generic lightbox functionality for any element. (similar to toFullScreen API)
  • Swipe navigation #8077
  • Custom lightbox for images with zoom and pan #8078
  • Custom lightbox for video players with autoplay
  • Experimental launch with two flags
  • Focused view
  • Detailed view #5151
  • Grid view
  • Lightboxable discovery service and grouping (automatically discover Lightboxable elements and groups them into one ore multiple lightbox albums)
  • Documentation & DevRel work

@aghassemi aghassemi added this to the Next milestone Jul 21, 2016

@aghassemi aghassemi self-assigned this Jul 21, 2016

@aghassemi aghassemi referenced this issue Jul 21, 2016

Open

[Punch List] - Video in AMP #4154

17 of 29 tasks complete
@aghassemi

This comment has been minimized.

Show comment
Hide comment
@aghassemi

aghassemi Jul 21, 2016

Member

@dvoytenko @ericlindley-g Rough punch list for lightbox 2.0 work. Feel free to edit.

Member

aghassemi commented Jul 21, 2016

@dvoytenko @ericlindley-g Rough punch list for lightbox 2.0 work. Feel free to edit.

@aghassemi

This comment has been minimized.

Show comment
Hide comment
Member

aghassemi commented Jul 22, 2016

cc @muxin

@ericlindley-g ericlindley-g added this to Backlog in UI Feb 13, 2017

@aghassemi aghassemi modified the milestones: New FRs, Sprint H2 Feb Feb 13, 2017

@ericlindley-g ericlindley-g moved this from Backlog (shortlist) to In Progress in UI Feb 27, 2017

@aghassemi aghassemi modified the milestones: New FRs, Sprint H2 Feb Feb 27, 2017

@ericlindley-g ericlindley-g moved this from In Progress to Sprint (candidate) in UI Mar 31, 2017

@ericlindley-g ericlindley-g moved this from Sprint (candidate) to Sprint (committed) in UI Apr 14, 2017

@muxin muxin removed their assignment Sep 6, 2017

@ampprojectbot

This comment has been minimized.

Show comment
Hide comment
@ampprojectbot

ampprojectbot Dec 18, 2017

Collaborator

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

Collaborator

ampprojectbot commented Dec 18, 2017

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@ericlindley-g ericlindley-g moved this from Sprint (committed) to Sprint (candidate) in UI Dec 21, 2017

@ericlindley-g ericlindley-g moved this from Sprint (candidate) to Sprint (committed) in UI Jan 5, 2018

@cathyxz cathyxz assigned cathyxz and unassigned aghassemi Feb 24, 2018

@cathyxz

This comment has been minimized.

Show comment
Hide comment
@cathyxz

cathyxz Feb 24, 2018

Collaborator

I think we no longer need this tracking issue, since most of this is done and the remainder is tracked via individual issues. E.g. video player support will be tracked in #12980.

Collaborator

cathyxz commented Feb 24, 2018

I think we no longer need this tracking issue, since most of this is done and the remainder is tracked via individual issues. E.g. video player support will be tracked in #12980.

@cathyxz cathyxz closed this Feb 24, 2018

@ericlindley-g ericlindley-g moved this from Sprint (committed) to Implemented (needs ABE sample) in UI Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment