Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing extensions to provide their own Loader animation #4299

Closed
mkhatib opened this issue Aug 1, 2016 · 4 comments

Comments

Projects
None yet
6 participants
@mkhatib
Copy link
Contributor

commented Aug 1, 2016

Currently there doesn't seem to be a way for extensions to provide their own loader animation. So extensions like Apster are (mis)using createPlaceholderCallback to provide their own gif animated image as a branded loader.

Maybe we can consider making the -amp-loader related CSS classes not private and allow extensions to override the animation. Or create a createLoaderElementCallback to allow extensions to provide their own.

@dandv

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2017

Any progress on this?

Alternatively, can we document the current node structure and classes for displaying the loader?

<div class="i-amphtml-loading-container i-amphtml-fill-content">
  <div class="i-amphtml-loader amp-active">
    <div class="i-amphtml-loader-dot"></div>
    <div class="i-amphtml-loader-dot"></div>
    <div class="i-amphtml-loader-dot"></div>
  </div>
</div>
@aghassemi

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2017

@dvoytenko

This comment has been minimized.

Copy link
Collaborator

commented Feb 21, 2017

Extensions can provide their loading indicators. E.g. Apester does.

@rudygalfi

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2017

So we can close?

@rudygalfi rudygalfi closed this Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.