Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change A4A validator to allow amp4ads-v0.js as runtime script #6154

Closed
lannka opened this issue Nov 11, 2016 · 5 comments
Closed

Change A4A validator to allow amp4ads-v0.js as runtime script #6154

lannka opened this issue Nov 11, 2016 · 5 comments
Assignees
@Gregable
Labels
WG: caching WG: monetization

Comments

@lannka
Copy link
Contributor

lannka commented Nov 11, 2016 •
edited

This is for #5700.

PR #6152 will change the A4A runtime script URL from v0.js to amp4ads-v0.js. Validator needs to get updated accordingly. We can let A4A validator allow either script for now (but not both), and be more strict when eventually launched amp-inabox.

@jasti
@Gregable
Copy link
Member

Update: the new plan is to use amp4ads-v0.js for naming consistency elsewhere.

@lannka lannka changed the title Change A4A validator to allow a4a-v0.js as runtime script Change A4A validator to allow amp4ads-v0.js as runtime script Nov 14, 2016
@lannka
Copy link
Contributor Author

lannka commented Nov 22, 2016

@Gregable is this already done?

@Gregable
Copy link
Member

I'll close the issue, because yes it is done in github. The change is not live though.

@honeybadgerdontcare
Copy link
Contributor

Change is now live.

@lannka
Copy link
Contributor Author

lannka commented Dec 9, 2016

@honeybadgerdontcare thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gregable Gregable

Labels
WG: caching WG: monetization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gregable @honeybadgerdontcare @lannka