New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete / suggestion field support in amp-form (enhancement) #6625

Closed
fliptheweb opened this Issue Dec 13, 2016 · 9 comments

Comments

@fliptheweb

fliptheweb commented Dec 13, 2016

Short description of your issue:

Implementation of autocomplete field in AMP.

Long description:

My company tries to reimplement rich js form to AMP version.
We have a autocomplete field (like react-autocomplete, jquery UI autocomplete, whatever) and I want to use the same functionality in AMP version.
Features:
– fetch remote JSON by XHR;
– custom render with amp-mustache;
– standard HTML validation.

For example:

<amp-autocomplete
    action-xhr="//api.com/search?term=search_term"
    name="origin"
    class="suggestions"
    placeholder="Choose your origin city"
    required />

<template type="amp-mustache">
  <div class="suggestions-item" amp-value="">{{text}} ({{iata}})</div>
</template>

Is it possible to implement autocomplete in AMP? Let's discuss.

@fliptheweb fliptheweb changed the title from Autocomplete / suggestion field support in amp-form to Autocomplete / suggestion field support in amp-form (enhancement) Dec 13, 2016

@jridgewell

This comment has been minimized.

Show comment
Hide comment
@jridgewell
Member

jridgewell commented Dec 13, 2016

/to @mkhatib

@jridgewell

This comment has been minimized.

Show comment
Hide comment
@jridgewell
Member

jridgewell commented Dec 20, 2016

@cramforce

This comment has been minimized.

Show comment
Hide comment
@cramforce

cramforce Dec 20, 2016

Member

CC @rudygalfi

Thanks for the report! This is definitely on our radar.

Member

cramforce commented Dec 20, 2016

CC @rudygalfi

Thanks for the report! This is definitely on our radar.

@rudygalfi

This comment has been minimized.

Show comment
Hide comment
@rudygalfi

rudygalfi Dec 20, 2016

Contributor

We're definitely looking into this. We've also got #3403 open for autocomplete, but I appreciate the additional detail you specified in your request.

Contributor

rudygalfi commented Dec 20, 2016

We're definitely looking into this. We've also got #3403 open for autocomplete, but I appreciate the additional detail you specified in your request.

@Rahul007shah

This comment has been minimized.

Show comment
Hide comment
@Rahul007shah

Rahul007shah May 12, 2017

Hi Team,

This is Rahul Shah from Priceline.com. We want Typeahead functionality in our home page. User types destination, From, To etc. fields to search for location. Autocomplete is show stopper to go live with AMP version of Priceline.com. Autocomplete feature is must in e-commerce applications as a basic feature, which will be useful for e-commerce platform to come on AMP platform.

Thanks
Rahul

Rahul007shah commented May 12, 2017

Hi Team,

This is Rahul Shah from Priceline.com. We want Typeahead functionality in our home page. User types destination, From, To etc. fields to search for location. Autocomplete is show stopper to go live with AMP version of Priceline.com. Autocomplete feature is must in e-commerce applications as a basic feature, which will be useful for e-commerce platform to come on AMP platform.

Thanks
Rahul

@aghassemi

This comment has been minimized.

Show comment
Hide comment
@aghassemi

aghassemi May 14, 2017

Member

Hi @Rahul007shah. We have started working on supporting autocomplete. Please see and subscribe to #8824 #8825
/cc @ericlindley-g

Member

aghassemi commented May 14, 2017

Hi @Rahul007shah. We have started working on supporting autocomplete. Please see and subscribe to #8824 #8825
/cc @ericlindley-g

@Rahul007shah

This comment has been minimized.

Show comment
Hide comment
@Rahul007shah

Rahul007shah May 15, 2017

Hi @aghassemi Thanks for the update.

Rahul007shah commented May 15, 2017

Hi @aghassemi Thanks for the update.

@adelinamart

This comment has been minimized.

Show comment
Hide comment
@adelinamart

adelinamart Jun 7, 2017

Collaborator

@aghassemi referenced issues are closed. Anything else to do here? Thanks

Collaborator

adelinamart commented Jun 7, 2017

@aghassemi referenced issues are closed. Anything else to do here? Thanks

@aghassemi

This comment has been minimized.

Show comment
Hide comment
@aghassemi

aghassemi Jun 7, 2017

Member

All the pieces are complete. Just needs a sample on AmpByExample, tracked under #9698
@Rahul007shah there is already a sample for this under https://github.com/ampproject/amphtml/blob/master/examples/autosuggest.amp.html which can get you going with the implementation. A more comprehensive sample coming soon with #9698

Member

aghassemi commented Jun 7, 2017

All the pieces are complete. Just needs a sample on AmpByExample, tracked under #9698
@Rahul007shah there is already a sample for this under https://github.com/ampproject/amphtml/blob/master/examples/autosuggest.amp.html which can get you going with the implementation. A more comprehensive sample coming soon with #9698

@aghassemi aghassemi closed this Jun 7, 2017

@ericlindley-g ericlindley-g moved this from Sprint (candidate) to Done in UI Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment