Hero mode for video players #7510

Open
aghassemi opened this Issue Feb 13, 2017 · 9 comments

Comments

@aghassemi
Member

aghassemi commented Feb 13, 2017

hero attribute on video players enables the following UX behavior:

  • Video is moved to the top of the page with full bleed.
  • Video autoplays
  • Docking UX for the playing video #8088
  • Maybe preload hero videos as part of preconnect (if not too heavy)
    hero attribute should be implemented as mostly a syntax sugar that brings existing independent effects.
    We already support autoplay.

@aghassemi aghassemi added this to the Sprint H2 Feb milestone Feb 13, 2017

@aghassemi aghassemi self-assigned this Feb 13, 2017

@aghassemi aghassemi referenced this issue Feb 13, 2017

Open

[Punch List] - Video in AMP #4154

17 of 29 tasks complete

@ericlindley-g ericlindley-g added this to Sprint Candidate in UI Feb 13, 2017

@ericlindley-g ericlindley-g removed this from Sprint Candidate in UI Feb 13, 2017

@ericlindley-g ericlindley-g added this to Sprint Candidate in UI Feb 13, 2017

@jpettitt

This comment has been minimized.

Show comment
Hide comment
@jpettitt

jpettitt Feb 14, 2017

Collaborator

Where did amp-fx-scrollbound suddenly spring from? Is there any design doc on the future of what sounds really useful feature for other scroll related things like showing a fixed mini-header/share bar when the main header scrolls off.

Collaborator

jpettitt commented Feb 14, 2017

Where did amp-fx-scrollbound suddenly spring from? Is there any design doc on the future of what sounds really useful feature for other scroll related things like showing a fixed mini-header/share bar when the main header scrolls off.

@jridgewell

This comment has been minimized.

Show comment
Hide comment
@jridgewell

jridgewell Feb 14, 2017

Member

Where did amp-fx-scrollbound suddenly spring from? Is there any design doc on the future of what sounds really useful feature for other scroll related things like showing a fixed mini-header/share bar when the main header scrolls off.

/cc @dvoytenko

Member

jridgewell commented Feb 14, 2017

Where did amp-fx-scrollbound suddenly spring from? Is there any design doc on the future of what sounds really useful feature for other scroll related things like showing a fixed mini-header/share bar when the main header scrolls off.

/cc @dvoytenko

@aghassemi

This comment has been minimized.

Show comment
Hide comment
@aghassemi

aghassemi Feb 14, 2017

Member

@jpettitt No design doc yet, but we did a hackaton on scroll-bound visual effects a while back ( you can see some of the work on this fork: https://github.com/ampproject/amphtml/commits/amp-scroll-sync, although the API will most likely change ).

Scroll-bound effects is back on our plate, current rough prioritization is to support a few named effects and later expose a generic framework for doing arbitrary transformation based on scrolling. To start, we plan to support:
1- parallax scrolling ( #1443 )
2- minimize-to-corner (this issue)
3- sticky & peekaboo headers (similar to browser address-bar or AMP viewer's header)
4- a generic framework for more advanced use-cases

If you have particular scroll-bound UX that you need, please let me know!
/cc @ericlindley-g

Member

aghassemi commented Feb 14, 2017

@jpettitt No design doc yet, but we did a hackaton on scroll-bound visual effects a while back ( you can see some of the work on this fork: https://github.com/ampproject/amphtml/commits/amp-scroll-sync, although the API will most likely change ).

Scroll-bound effects is back on our plate, current rough prioritization is to support a few named effects and later expose a generic framework for doing arbitrary transformation based on scrolling. To start, we plan to support:
1- parallax scrolling ( #1443 )
2- minimize-to-corner (this issue)
3- sticky & peekaboo headers (similar to browser address-bar or AMP viewer's header)
4- a generic framework for more advanced use-cases

If you have particular scroll-bound UX that you need, please let me know!
/cc @ericlindley-g

@jpettitt

This comment has been minimized.

Show comment
Hide comment
@jpettitt

jpettitt Feb 15, 2017

Collaborator

#1 and #3 are both things we'd like. Peekaboo footers would be nice too (generic version of amp-sticky-ad)

Collaborator

jpettitt commented Feb 15, 2017

#1 and #3 are both things we'd like. Peekaboo footers would be nice too (generic version of amp-sticky-ad)

@zhouyx

This comment has been minimized.

Show comment
Hide comment
@zhouyx

zhouyx Feb 15, 2017

Collaborator

FYI: As already found with amp-sticky-ad. In safari, swipe to dismiss won't work with element placed at the bottom of the page, and bottom navigation bar hidden.

Collaborator

zhouyx commented Feb 15, 2017

FYI: As already found with amp-sticky-ad. In safari, swipe to dismiss won't work with element placed at the bottom of the page, and bottom navigation bar hidden.

@ericlindley-g ericlindley-g moved this from Sprint Candidate to In Progress in UI Feb 17, 2017

@aghassemi aghassemi referenced this issue Mar 13, 2017

Open

Docking UX for video players #8088

4 of 4 tasks complete

@aghassemi aghassemi removed this from In Progress in UI Mar 13, 2017

@ericlindley-g ericlindley-g added this to Needs Triage in UI Apr 14, 2017

@ericlindley-g ericlindley-g moved this from Needs Triage to Backlog in UI May 25, 2017

@ampprojectbot

This comment has been minimized.

Show comment
Hide comment
@ampprojectbot

ampprojectbot Oct 30, 2017

Collaborator

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

Collaborator

ampprojectbot commented Oct 30, 2017

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@ampprojectbot

This comment has been minimized.

Show comment
Hide comment
@ampprojectbot

ampprojectbot Jan 29, 2018

Collaborator

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

Collaborator

ampprojectbot commented Jan 29, 2018

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@ampprojectbot

This comment has been minimized.

Show comment
Hide comment
@ampprojectbot

ampprojectbot Jun 5, 2018

Collaborator

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

Collaborator

ampprojectbot commented Jun 5, 2018

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@aghassemi

This comment has been minimized.

Show comment
Hide comment
@aghassemi

aghassemi Jun 8, 2018

Member

not prioritize

Member

aghassemi commented Jun 8, 2018

not prioritize

@aghassemi aghassemi added P3: When Possible and removed P2: Soon labels Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment