Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Task breakdown for #7510
Format for docking videos
UX for docking videos
@dpetrieldn For the docking location, it is certainly possible to expose an option. Initially we are thinking not to expose that in the hopes of providing a unified UX across all AMP pages (always top-right) and allow the user to move it instead of publisher deciding where it docks.
Definitely open for discussion though. Is there a specific use-cases for you that must require docking somewhere other than top-right? (Of course for RTL pages, we would automatically flip to dock on top-left).
Another option we are exploring here is: instead of an option to pick where to dock, allowing authors to put a
Could you elaborate on this design a bit more? (We haven't fully flushed out multiple video UX yet). Does something like the following cover the design you had in mind:
Multi video pages
Docking player in different locations
Likewise we wouldn't ideally want the player to obscure content either (at least obscure anything as little as possible) but should the content column be on the right side we'd be into a similar issue, where we would want it docked to the bottom left.
In either case we would want to avoid the player covering any high value commercial elements, or to be able to at least limit this.
Some additional thoughts
Docking effect on pre-rolls
Orientation restrictions/media queries
Apologies for the long post, hopefully this answers some questions and prompts extra discussion on the UX.
Thanks for the details write-up @dpetrieldn! This is absolutely great that you are sharing your requirements with us before we implement a feature!
I will keep these in mind as we work on the implementation. Everything looks reasonable to support. The API design for docking location and docking triggers might be the harder part to get right. For
I am also curious to know what video player you are using. Do you have a custom in-house solution and use
Hey @aghassemi, we tried using scale on non amp pages with the Brightcove player but it had an impact on the player controls that proved to be unworkable, however we didn't go into it in much depth past an initial attempt.
As per @bjalford 's comment, its a Brightcove player 99% of the time, but in very rare instances we have other players in use, typically across your standard embeds like youtube for example.
With our Brightcove player we would also actually love to have some form of end board, appreciate it may not have a place in this issue but may be something to consider.
Would love to be an early adopter for this, just to make that clear! So happy to answer any questions or provide more specific feedback if required.
@bjalford @dpetrieldn Thanks for more info. Our initial design assumed we hide the player controls and instead put our own controls on top of the video (limited controls with large tap targets) when minimized.
Just another note that work on this feature is on pause at the moment for higher priority tasks.