Base/dummmy implementation of amp-story extension #11330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
approved these changes
Sep 19, 2017
13 tasks
dvoytenko
suggested changes
Sep 28, 2017
css/amp.css
Outdated
|
|
||
| amp-story-page { | ||
| background-color: #757575; | ||
| } |
| * amp-story | ||
| */ | ||
| amp-story, amp-story-page { | ||
| display: block; |
There was a problem hiding this comment.
Static positioning OK? Not relative or absolute? Or is this up to the actual extension amp-story.css?
There was a problem hiding this comment.
Static positioning is okay here. Since the height is 100vh and the pages will lay out vertically, we'll start preloading resources for the first few viewports (based on whatever the runtime does by default). When amp-story.css is loaded, it will override this to style the story appropriately.
| } | ||
|
|
||
| buildCallback() { | ||
| this.isExperimentOn_ = isExperimentOn(this.win, TAG); |
There was a problem hiding this comment.
We just usually do user().assert(isExperimentOn(...), 'enable X experiment'). No need for private vars and such.
| { | ||
| id: 'amp-story', | ||
| name: 'Visual storytelling in AMP', | ||
| spec: 'https://github.com/ampproject/amphtml/issues/11329', |
There was a problem hiding this comment.
Create cleanup bug and include here as well.
dvoytenko
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the basic structure of a new
amp-storyextension, per the intent to implement in #11329.