Add ad-serving-integration.md for AMP story #13349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcordry
reviewed
Feb 7, 2018
|
|
||
| ## Custom ad | ||
|
|
||
| Story publisher can do self-served ads using the [Custom ad](../../ads/custom.md) |
| ## THIS IS A WORK-IN-PROGRESS | ||
|
|
||
| This article is for parties who want to serve ads into AMP stories. If you're a | ||
| publisher who wants to monetize your stories, go for [monetize with story](./monetize-with-story.md) instead, |
There was a problem hiding this comment.
publisher who wants to monetize your stories, please refer to monetize with story unless you want to serve ads by yourselves.
| and data fetched remotely. | ||
|
|
||
| ### Template | ||
| An ad template will be written in [amp-mustache](../amp-mustache/amp-mustache.md). |
| ``` | ||
|
|
||
| Important things | ||
| - An element ID is required, so that the template can be reference by the ad response. |
|
|
||
| Important things | ||
| - An element ID is required, so that the template can be reference by the ad response. | ||
| - Templates need to be inlined in the AMP Story, as a direct children of `<amp-story>` element. |
| - The content inside a template should strictly follow the [rules](https://github.com/ampproject/amphtml/blob/master/extensions/amp-story/validator-amp-story.protoascii) of `amp-story-grid-layer` | ||
| - Be aware of the [restrictions](../amp-mustache/amp-mustache.md#Restrictions) of `amp-mustache`. | ||
|
|
||
| To provide a consistent user experience, CTA (call-to-action) button should NOT |
|
|
||
| To provide a consistent user experience, CTA (call-to-action) button should NOT | ||
| be included in the template. Story defines a list of CTA buttons to select from. | ||
| For details, read the "CTA ad" section below. |
| - `templateId`: the ID of the inlined template that is going to be used. | ||
| - `data`: the data model to populate the selected template. The fields should match the variable names in the selected template. | ||
| - `var`: extra variables needed by the story. They will be added to the `amp-ad` element as data attributes, and picked by runtime for different use cases: | ||
| - CTA button rendering (see details in the "CTA ad" section) |
| generated page ID, prefixed with `i-amphtml-AD-`. `story-page-visible` trigger | ||
| can be used to track ad views. | ||
|
|
||
| Further more, ad response can leverage the `var` object to put data attributes |
There was a problem hiding this comment.
Further more, the ad ... to pass data ... tag, to be used ...
last part should be as a data var (singular) OR as data vars (plural)
jasti
approved these changes
Feb 7, 2018
|
All comments addressed. PTAL |
newmuis
approved these changes
Feb 8, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
* Add ad-serving-integration.md for AMP story * talk about ads styling * Addressing comments * Fix broken links * fix travis
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Add ad-serving-integration.md for AMP story * talk about ads styling * Addressing comments * Fix broken links * fix travis
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* Add ad-serving-integration.md for AMP story * talk about ads styling * Addressing comments * Fix broken links * fix travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12381