Copy amp-story 1.0 back to 0.1 #14626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
approved these changes
Apr 16, 2018
|
@gmajoulet I think that might fail the CLA check? |
|
Added @jridgewell to take a look for the change to the bundle size (baf2670) |
jridgewell
requested changes
Apr 16, 2018
| * @param {!Window} win | ||
| * @return {?Promise<?../extensions/amp-story/0.1/variable-service.StoryVariableDef>} | ||
| */ | ||
| static storyVariableServiceForOrNullV01(win) { |
There was a problem hiding this comment.
Can we reuse the same services, passing in an optional parameter for the version?
There was a problem hiding this comment.
This will be pretty complicated since the services' functions return different types, so we'll have to change every usage downstream
jridgewell
approved these changes
Apr 17, 2018
glevitzky
pushed a commit
that referenced
this pull request
Apr 27, 2018
* Initial copy of 1.0 => 0.1 * Create separate services for v0.1 * Update 0.1 tests to use 0.1 services * Increase uncompiled bundle size from 334.46kb to 334.55kb * Wrong version for system-layer tests * Update inline styles for page scaling to new API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second step of #14357: removing the alias from 0.1=>1.0, and instead having separate codebases for each. This is necessary to hold breaking changes in 1.0 until later (since, if they were aliased, any breaking changes in 1.0 would also go. to 0.1).
Note that git won't hint these files, since it's not a move. Also note that a separate copy of the service getters had to be made, since the implementations are different types (see 07fd2fd).