From 70f7a8d8c1d54ad5e30b695edcb5a7f08e1682ea Mon Sep 17 00:00:00 2001 From: Patrick Roche Date: Mon, 3 Dec 2018 14:21:21 -0500 Subject: [PATCH 1/2] Remove dead links in amp-access-analytics doc Remove links to ./amp-access-spec.md#login-page. The related content has not yet been added to the Detailed Discussion section of amp-access.md. --- extensions/amp-access/amp-access-analytics.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/extensions/amp-access/amp-access-analytics.md b/extensions/amp-access/amp-access-analytics.md index 35e2845c68e6..0ce52110654c 100644 --- a/extensions/amp-access/amp-access-analytics.md +++ b/extensions/amp-access/amp-access-analytics.md @@ -91,7 +91,7 @@ The `access-pingback-failed` event is issued when the Pingback endpoint has fail The `access-login[-type]-started` event is issued right before the Login dialog has been opened. Use these configurations to fire a request for this event. -When only one Login URL is configured, the event is `access-login-started`. When multiple Login URLs are configured, the event is `access-login-type-started`, e.g. "access-login-signup-started". See [Login Page Spec](./amp-access-spec.md#login-page) for more info. +When only one Login URL is configured, the event is `access-login-started`. When multiple Login URLs are configured, the event is `access-login-type-started`, e.g. "access-login-signup-started". ```javascript "triggers": { @@ -106,7 +106,7 @@ When only one Login URL is configured, the event is `access-login-started`. When The `access-login[-type]-success` event is issued when Login dialog has succeeded. Use these configurations to fire a request for this event. -When only one Login URL is configured, the event is `access-login-success`. When multiple Login URLs are configured, the event is `access-login-type-success`, e.g. "access-login-signup-success". See [Login Page Spec](./amp-access-spec.md#login-page) for more info. +When only one Login URL is configured, the event is `access-login-success`. When multiple Login URLs are configured, the event is `access-login-type-success`, e.g. "access-login-signup-success". ```javascript "triggers": { @@ -121,7 +121,7 @@ When only one Login URL is configured, the event is `access-login-success`. When The `access-login[-type]-rejected` event is issued when Login dialog has been rejected by the user. Use these configurations to fire a request for this event. -When only one Login URL is configured, the event is `access-login-rejected`. When multiple Login URLs are configured, the event is `access-login-type-rejected`, e.g. "access-login-signup-rejected". See [Login Page Spec](./amp-access-spec.md#login-page) for more info. +When only one Login URL is configured, the event is `access-login-rejected`. When multiple Login URLs are configured, the event is `access-login-type-rejected`, e.g. "access-login-signup-rejected". ```javascript "triggers": { @@ -136,7 +136,7 @@ When only one Login URL is configured, the event is `access-login-rejected`. Whe The `access-login[-type]-failed` event is issued when Login dialog has failed due to an unknown reason. Use these configurations to fire a request for this event. -When only one Login URL is configured, the event is `access-login[-type]-failed`. When multiple Login URLs are configured, the event is `access-login-type-failed`, e.g. "access-login-signup-failed". See [Login Page Spec](./amp-access-spec.md#login-page) for more info. +When only one Login URL is configured, the event is `access-login[-type]-failed`. When multiple Login URLs are configured, the event is `access-login-type-failed`, e.g. "access-login-signup-failed". ```javascript "triggers": { From a8e7ab202ba8acba805472ba3da14e9ffe5a10c2 Mon Sep 17 00:00:00 2001 From: Patrick Roche Date: Fri, 7 Dec 2018 16:33:47 -0500 Subject: [PATCH 2/2] Fix link to amp-var-substitutions doc Add missing double-dot notation to relative link. The link was failing a Travis CI test. --- extensions/amp-access/amp-access-analytics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/amp-access/amp-access-analytics.md b/extensions/amp-access/amp-access-analytics.md index 0ce52110654c..e34e63133c4c 100644 --- a/extensions/amp-access/amp-access-analytics.md +++ b/extensions/amp-access/amp-access-analytics.md @@ -149,7 +149,7 @@ When only one Login URL is configured, the event is `access-login[-type]-failed` ## Access analytics variables -Access contributes the following URL substitutions to the [amp-var-substitutions.md](/spec/amp-var-substitutions.md). +Access contributes the following URL substitutions to the [amp-var-substitutions.md](../../spec/amp-var-substitutions.md). ### ACCESS_READER_ID