Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈馃悰 Don't run clean during build, check-types, or dist #22455

Merged
merged 3 commits into from May 23, 2019
Merged

馃彈馃悰 Don't run clean during build, check-types, or dist #22455

merged 3 commits into from May 23, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 23, 2019

Addresses #22380 (comment)
Follow up to #22380

@rsimha rsimha requested a review from dreamofabear May 23, 2019 00:29
@rsimha rsimha self-assigned this May 23, 2019
@rsimha rsimha mentioned this pull request May 23, 2019
Merged
@rsimha
Copy link
Contributor Author

rsimha commented May 23, 2019

/to @choumx

@dreamofabear
Copy link

I don't think we should clean during check-types or dist either. :)

@rsimha rsimha changed the title 馃彈馃悰 Don't run clean during build 馃彈馃悰 Don't run clean during build, check-types, or dist May 23, 2019
@rsimha
Copy link
Contributor Author

rsimha commented May 23, 2019 •
edited

I don't think we should clean during check-types or dist either. :)

Fair enough. Moved it to just those tests that require a clean state.

@rsimha rsimha merged commit b1afbe2 into ampproject:master May 23, 2019
@rsimha rsimha deleted the 2019-05-22-BuildShadow branch May 23, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees

@rsimha rsimha

Labels
cla: yes WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsimha @dreamofabear @googlebot