Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js #22504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
redirecting to @lannka |
|
add @rsimha for reviewing as it might be related to the recent closure compiler change |
The Travis run still shows flakiness on Firefox.
zombifier
changed the title
rsimha
approved these changes
May 29, 2019
rsimha
approved these changes
May 29, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
…mpproject#22504) * Reenable test * Bandaid to fix installInEmbedWindow failing in compiled local testing. * Add nocollapse to allowed tags * Skip test on Firefox (like before the change). The Travis run still shows flakiness on Firefox. * Unskip the remaining test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22572. Seems like it's now failing due to a regression (function being stripped from compiled code).